Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTwitter homepage tabs don't fill boxes #18811
Open
Comments
|
Minimal testcase: <!DOCTYPE html>
<style>
.StreamsTopBar {
border-bottom: 1px solid #ff0000;
box-sizing: border-box;
height: 270px;
}
.StreamsHero {
height: 210px;
}
h2 {
margin-bottom: -5px;
}
a {
border-bottom: 0 solid #1da1f2;
border-bottom-width: 5px;
height: 59px;
display: block;
box-sizing: border-box;
}
</style>
<div class="StreamsTopBar">
<div class="StreamsHero">
<h2>What’s happening?</h2>
</div>
<a></a>
</div>Firefox: Servo: |
bors-servo
added a commit
that referenced
this issue
Nov 26, 2017
…=<try> fix collapsing margins fallthrough calculations Margins that should not collapse through where still effecting the layout of subsequent elements <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18811 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19386) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 27, 2017
…=<try> fix collapsing margins fallthrough calculations Margins that should not collapse through where still effecting the layout of subsequent elements <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18811 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19386) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jan 4, 2018
…=<try> fix collapsing margins fallthrough calculations Margins that should not collapse through where still effecting the layout of subsequent elements <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18811 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19386) <!-- Reviewable:end -->
|
This can be reproduced in a14b952 |
|
Not a problem in layout 2020, still a problem in layout 2013 (the PR was never merged)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Firefox:
Servo:
