Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey sprites out of place in Evil Ad demo #18860

Open
atouchet opened this issue Oct 13, 2017 · 5 comments
Open

Monkey sprites out of place in Evil Ad demo #18860

atouchet opened this issue Oct 13, 2017 · 5 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 13, 2017

Evil Ad

I believe the monkey sprites are supposed to be contained within the ad box. Tested with latest nightly build in Windows 10.

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Nov 17, 2017

In the most recent nightly build it appears that moving the cursor over the monkey sprites causes them to move back down to where they are supposed to be. The ad also initially shows up as scrollable.

@atouchet atouchet changed the title Monkey sprites out of place in Evil Ad demo Monkey sprites out of place and ad box scrollable in Evil Ad demo Nov 17, 2017
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Nov 21, 2017

I don't know if this really helps at all but with-ad.html can be reduced to:

<!DOCTYPE html>
<html>
<body>
<iframe id="ad" src="ad.html" width="728" height="90" sandbox="allow-scripts" scrolling="no"></iframe>
</body>
</html>
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Dec 20, 2017

This is still an issue in the latest nightly build although the behaviour has changed somewhat. The monkey sprites are now clipped by the ad box and no longer appear above it.

Evil Ad

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Jan 17, 2018

I bisected this regression and it first occurred in the 2017-08-19 Servo nightly build.

@atouchet atouchet changed the title Monkey sprites out of place and ad box scrollable in Evil Ad demo Monkey sprites out of place in Evil Ad demo Jan 18, 2019
@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Jan 18, 2019

The ad is no longer scrollable but the monkey sprites are still out of place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.