Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ./mach bootstrap-rust and ./mach bootstrap-cargo #18874

Closed
nox opened this issue Oct 14, 2017 · 7 comments
Closed

Merge ./mach bootstrap-rust and ./mach bootstrap-cargo #18874

nox opened this issue Oct 14, 2017 · 7 comments
Labels
A-mach I-papercut L-python

Comments

@nox
Copy link
Member

@nox nox commented Oct 14, 2017

They share the same version numbers now anyway.
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Oct 26, 2017

Is there more information about this issue?
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 26, 2017

These sub-commands are defined in python/servo/bootstrap_commands.py. It’s not useful to run one without the other, so they could both be replaced with one. Note however that there’s already an existing bootstrap sub-command that does something else.
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Oct 26, 2017

How do you suggest to solve this? Is it a good way to name a new sub-command to combine them? And what should the new sub-command name?
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 26, 2017

I guess folding bootstrap-cargo into bootstrap-rust (keeping the latter’s name) would work.
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 26, 2017

Though personally I don’t care much about doing that v.s. the status quo, I usually run ./mach fetch to fetch/bootstrap everything. Maybe @nox, having filed this issue, has opinions.
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Nov 23, 2017

@nox How do you think?
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Nov 27, 2017

I’m starting to work on #11361. Both subcommands will probably be removed in the process, making this issue moot.
SimonSapin added a commit that referenced this issue Nov 27, 2017
@SimonSapin
Use rustup.rs instead of custom bootstrap
f6168b6 
Fixes #11361, closes #18874
@SimonSapin SimonSapin mentioned this issue Nov 27, 2017
Merged
SimonSapin added a commit that referenced this issue Nov 28, 2017
@SimonSapin
Use rustup.rs instead of custom bootstrap
037b4fa 
Fixes #11361, closes #18874
SimonSapin added a commit that referenced this issue Dec 9, 2017
@SimonSapin
Use rustup.rs instead of custom bootstrap
35c2cc6 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Dec 12, 2017
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
91a9ad6 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Dec 14, 2017
@SimonSapin
Use rustup.rs instead of custom bootstrap
9fa9ea1 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Dec 14, 2017
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
8242fda 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Dec 19, 2017
@SimonSapin
Use rustup.rs instead of custom bootstrap
66992d4 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Dec 19, 2017
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
24a867f 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Dec 19, 2017
@SimonSapin
Use rustup.rs instead of custom bootstrap
f36ba1d 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Dec 19, 2017
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
a484ce4 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Dec 20, 2017
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
71a37a6 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Jan 7, 2018
@SimonSapin
Use rustup.rs instead of custom bootstrap
7e7eb1c 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Jan 7, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
b771b95 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 8, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
0315b38 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
865990b 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
2099889 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
1ae8b6d 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
f5135c2 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Jan 9, 2018
@SimonSapin
Use rustup.rs instead of custom bootstrap
4230e72 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=jdm
Loading status checks…
4c4baa4 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Jan 9, 2018
@SimonSapin
Use rustup.rs instead of custom bootstrap
1bc8489 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=jdm
Loading status checks…
a618ade 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 10, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
e1f2fad 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 10, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
d033780 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 10, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=<try>
Loading status checks…
f26eb55 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
SimonSapin added a commit that referenced this issue Jan 10, 2018
@SimonSapin
Use rustup.rs instead of custom bootstrap
365a139 
Fixes #11361, closes #18874
bors-servo added a commit that referenced this issue Jan 10, 2018
@bors-servo
Auto merge of #19395 - servo:rustup.rs, r=jdm
Loading status checks…
2be49ac 
Use rustup.rs instead of custom bootstrap

Fixes #11361, closes #18874, fixes #19365.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19395)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mach I-papercut L-python
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use rustup.rs instead of custom bootstrap
3 participants
@nox @SimonSapin @tigercosmos
You can’t perform that action at this time.