Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused import #18916

Closed
tigercosmos opened this issue Oct 17, 2017 · 4 comments
Closed

unused import #18916

tigercosmos opened this issue Oct 17, 2017 · 4 comments

Comments

@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Oct 17, 2017

On commit eecee32a0b139096e8fe268590536b2eb5ac911d

warning: unused import: `MatchingMode`
  --> C:\Users\123\Desktop\servo\components\script\dom\element.rs:92:66
   |
92 | use selectors::matching::{ElementSelectorFlags, MatchingContext, MatchingMode, RelevantLinkStatus};
   |                                                                  ^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default
@tigercosmos tigercosmos changed the title unuse import unused import Oct 17, 2017
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 17, 2017

I believe this is fixed in 4c5d6fd. Thanks for the report!
@SimonSapin SimonSapin closed this Oct 17, 2017
@tigercosmos
Copy link
Collaborator Author

@tigercosmos tigercosmos commented Oct 17, 2017

@SimonSapin Seems not?
https://github.com/servo/servo/blob/master/components/script/dom/element.rs#L92
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 17, 2017

Oh indeed, sorry. I can reproduce on master, I suppose another PR re-introduced that warning.
@SimonSapin SimonSapin reopened this Oct 17, 2017
@tigercosmos
Copy link
Collaborator Author

@tigercosmos tigercosmos commented Oct 17, 2017

I will do it.
@tigercosmos tigercosmos mentioned this issue Oct 17, 2017
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Oct 17, 2017
@bors-servo
Auto merge of #18919 - tigercosmos:remove, r=SimonSapin
Loading status checks…
7704fa0 
fix unused warning

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18916

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18919)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix unused warning
2 participants
@SimonSapin @tigercosmos
You can’t perform that action at this time.