Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectors: Reformat signatures in the parser module. #18983

Merged
merged 1 commit into from Oct 22, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Oct 22, 2017

I was doing something unrelated with this code, and each signature uses a
different style. This PR unifies them.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/selectors/parser.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 22, 2017
@emilio
Copy link
Member Author

emilio commented Oct 22, 2017

r? @nox or @SimonSapin (or anyone else)

I was doing something unrelated with this code, and each signature uses a
different style. This PR unifies them.
@jdm
Copy link
Member

jdm commented Oct 22, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit e1aa829 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Oct 22, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 22, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit e1aa829 with merge a296e38...

bors-servo pushed a commit that referenced this pull request Oct 22, 2017
selectors: Reformat signatures in the parser module.

I was doing something unrelated with this code, and each signature uses a
different style. This PR unifies them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18983)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing a296e38 to master...

@bors-servo bors-servo merged commit e1aa829 into servo:master Oct 22, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants