Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolutes are not shrinking to fit properly in Acid2 #1900

Closed
pcwalton opened this issue Mar 13, 2014 · 2 comments
Closed

Absolutes are not shrinking to fit properly in Acid2 #1900

pcwalton opened this issue Mar 13, 2014 · 2 comments

Comments

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Mar 13, 2014

Line 2 blockquote problem in Acid2.

/cc @pradeep90

@pcwalton pcwalton added this to the Layout: Acid2 milestone Mar 13, 2014
@pradeep90
Copy link
Contributor

@pradeep90 pradeep90 commented Mar 13, 2014

@pcwalton I believe it is because of #1708
In bubble_width, calculation of pref width and min width is wrong (because it adds in margins and stuff).

Box::guess_width gives up

width + margin_left + margin_right + padding_left + padding_right + self.border.get().left + self.border.get().right

as the value for the content width o_0

So, for the blockquote in acid2.html, we get shrink-to-fit width as width of float kid + our margin + our border

@SimonSapin suggested using http://dev.w3.org/csswg/css-sizing/#max-content-measuremax-measuremax-content-size as reference for the min and pref width calculation because it is more precise than the CSS 2.1 reference.

@pcwalton
Copy link
Contributor Author

@pcwalton pcwalton commented Sep 11, 2014

Fixed.

@pcwalton pcwalton closed this Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.