Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit detection issue with duckduckgo.com/html search button #19052

Closed
atouchet opened this issue Oct 28, 2017 · 3 comments
Closed

Hit detection issue with duckduckgo.com/html search button #19052

atouchet opened this issue Oct 28, 2017 · 3 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Oct 28, 2017

URL: https://duckduckgo.com/html/

On the duckduckgo.com/html main page the entire search button should be clickable but in Servo it is only clickable when the mouse is above the edges of the button or above the magnifying glass icon. The button is not clickable otherwise. Tested in Windows 10 with Browser.html.

@bobthekingofegypt
Copy link
Contributor

@bobthekingofegypt bobthekingofegypt commented Oct 31, 2017

I created a sample page that appears to show how the presence of border-radius causes the hit detection issue.

https://gist.github.com/bobthekingofegypt/579dac0a93acb4f55a4d720294836acb

@atouchet
Copy link
Contributor Author

@atouchet atouchet commented Nov 10, 2017

This is fixed now although there are still some issues with the button on the search page.

Edit: The search page button issues are now fixed.

@atouchet atouchet closed this Nov 10, 2017
@bobthekingofegypt
Copy link
Contributor

@bobthekingofegypt bobthekingofegypt commented Nov 10, 2017

Incase it comes up again and someone looks back at this, this was fixed by #19169 which contains an update to webrender.

This diff servo/webrender@aa74cdf...3a0ddfc should cover the relavant commits from the WR release. Something in there fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.