External scripts in an XML document mess up the namespace map #19087

jdm · 2017-11-01T17:47:42Z

foo.xhtml:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<script src='foo.js' />
</head>
<body>
<script>console.log('inline script')</script>
</body>
</html>

foo.js:

console.log('external script')

When loaded from a server that provides the application/xhtml+xml, this yields the output:

external script

because the inline script element receives an empty namespace when it's being created by the parser, so we only create an Element instead of an HTMLScriptElement.


        Auto merge of #324 - servo:xml-namespace, r=nox

Reset namespace stack when processing an empty script tag This addresses the problem from servo/servo#19087. Non-script empty tags go through the `append_tag` code path which does not pop anything from the namespace stack. Empty script tags go through insert_tag/close_tag instead, which does pop an element from the namespace stack.

jdm · 2018-02-05T13:54:38Z

This was fixed by servo/html5ever@3c993fa#diff-e1bfdf8803c27281c69f3f0bb30729cf.

jdm added A-content/parsers C-has-manual-testcase labels Nov 1, 2017

jdm mentioned this issue Nov 1, 2017

Reset namespace stack when processing an empty script tag servo/html5ever#324

Merged

jdm closed this Feb 5, 2018

servo / servo

External scripts in an XML document mess up the namespace map #19087

External scripts in an XML document mess up the namespace map #19087

jdm commented Nov 1, 2017

jdm commented Feb 5, 2018

servo / servo

Join GitHub today

External scripts in an XML document mess up the namespace map #19087

External scripts in an XML document mess up the namespace map #19087

Comments

jdm commented Nov 1, 2017

jdm commented Feb 5, 2018