Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate document URL when a new history state is pushed/replaced #19157
Labels
Comments
|
I worked on this and submitted a PR #20453 since I didn't see a |
|
No worries, I've been a bit busy and should've unassigned myself. |
bors-servo
added a commit
that referenced
this issue
Apr 18, 2018
History: update document URL on pushState/replaceState <!-- Please describe your changes on the following line: --> Update Document URL when calling pushState and replaceState on History. https://html.spec.whatwg.org/multipage/#dom-history-pushstate Steps 6, 7, 10 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19157 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20453) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Apr 19, 2018
History: update document URL on pushState/replaceState <!-- Please describe your changes on the following line: --> Update Document URL when calling pushState and replaceState on History. https://html.spec.whatwg.org/multipage/#dom-history-pushstate Steps 6, 7, 10 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19157 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20453) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Apr 19, 2018
History: update document URL on pushState/replaceState <!-- Please describe your changes on the following line: --> Update Document URL when calling pushState and replaceState on History. https://html.spec.whatwg.org/multipage/#dom-history-pushstate Steps 6, 7, 10 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #19157 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20453) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of #10992
https://html.spec.whatwg.org/multipage/#dom-history-pushstate Step 10