Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDouble borrow in Box::padding_box_size #1926
Closed
Labels
Comments
|
This does not happen when parallel layout is disabled (-y 1) |
bors-servo
pushed a commit
that referenced
this issue
Apr 4, 2014
bors-servo
pushed a commit
that referenced
this issue
May 2, 2014
layout: Re-enable parallel layout by removing all `RefCell` instances from `Flow`s; in the process, remove `InlineInfo` in favor of the range-based design that was originally planned and halfway implemented. Now, the DOM tree structure for inline flows is reflected not by a series of arrays but instead by a flat list of ranges into the list of boxes. As part of this, the `border` and `padding` fields, which were incorrect in the case of inlines and necessitated separate `noncontent_inline_foo` methods, have been merged into a single `border_padding` field that is always guaranteed to be correct after width assignment, even for inlines. r? @SimonSapin and/or @larsbergstrom Closes #1280 Closes #1926 Closes #1999 Closes #2013 Closes #2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
STR:
./servo http://www.bing.comActual:
task 'task 'task '<unnamed>' failed at '<unnamed>assertion failed: self.parent.borrow != WRITING && self.parent.borrow != UNUSED<unnamed>' failed at '' failed at 'RefCell<T> already mutably borrowed', ', RefCell<T> already mutably borrowed/src/compiler/rust/src/libstd/cell.rs/src/compiler/rust/src/libstd/cell.rs', :/src/compiler/rust/src/libstd/cell.rs248 ::135135(sic)