Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement create-an-element-for-a-token algorithm #19392

Closed
jdm opened this issue Nov 27, 2017 · 2 comments
Closed

Implement create-an-element-for-a-token algorithm #19392

jdm opened this issue Nov 27, 2017 · 2 comments
Assignees
@cbrewster
Labels
A-content/dom

Comments

@jdm
Copy link
Member

@jdm jdm commented Nov 27, 2017 •
edited

create_html_element implements https://dom.spec.whatwg.org/#concept-create-element and is called from the parser (via Element::create in Sink::create_element), but the HTML specification defines https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token which is used by the HTML parsing algorithms. Steps 6 and 9 are particularly relevant for dealing with #19307 (comment).
@jdm jdm added the A-content/dom label Nov 27, 2017
This was referenced Nov 27, 2017
Closed
Merged
@jdm
Copy link
Member Author

@jdm jdm commented Nov 27, 2017

@cbrewster Any chance you feel like fixing this?
@cbrewster cbrewster self-assigned this Nov 27, 2017
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Nov 27, 2017

@jdm Yeah I can work on this.
@cbrewster cbrewster mentioned this issue Nov 27, 2017
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Jan 4, 2018
@bors-servo
Auto merge of #19397 - cbrewster:create_element_for_token, r=<try>
Loading status checks…
5f72bae 
Implement the create an element for token algorithm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19392 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19397)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 8, 2018
@bors-servo
Auto merge of #19397 - cbrewster:create_element_for_token, r=<try>
Loading status checks…
3fc40f7 
Implement the create an element for token algorithm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19392 and fix #19393 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19397)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19397 - cbrewster:create_element_for_token, r=<try>
Loading status checks…
141192d 
Implement the create an element for token algorithm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19392 and fix #19393 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19397)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jan 17, 2018
@bors-servo
Auto merge of #19397 - cbrewster:create_element_for_token, r=jdm,nox
Loading status checks…
fa82a6b 
Implement the create an element for token algorithm

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19392 and fix #19393 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19397)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbrewster cbrewster

Labels
A-content/dom
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement the create an element for token algorithm
2 participants
@jdm @cbrewster
You can’t perform that action at this time.