Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text colour wrong in GitHub text boxes #19401

Open
atouchet opened this issue Nov 28, 2017 · 7 comments
Open

Text colour wrong in GitHub text boxes #19401

atouchet opened this issue Nov 28, 2017 · 7 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Nov 28, 2017

URL: https://github.com/

The colours of the text box text in GitHub are off. In Firefox they appear grey but in Servo they show up as black and white.

Image of issue (Firefox left, Servo right):

GitHub text boxes

See "Search GitHub" and the sign up boxes. Tested in Windows 10 with Browser.html.

@paulrouget paulrouget mentioned this issue Nov 28, 2017
14 of 24 tasks complete
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Nov 28, 2017

Where is the suspected code that can fix this? CSS read color?

@emilio
Copy link
Member

@emilio emilio commented Nov 28, 2017

That's the input placeholder.

@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Nov 28, 2017

Are there any code that dealing with color of placeholder?

@jdm
Copy link
Member

@jdm jdm commented Nov 28, 2017

The placeholder code works by providing layout with the placeholder text content when layout asks for it, then layout styles it like non-placeholder content:

@ferjm ferjm self-assigned this Jan 17, 2018
@ferjm
Copy link
Member

@ferjm ferjm commented Jan 18, 2018

I think there are a couple of issues here:

With a reduced test case like:

<html>
<head>
  <style>
  input {
      color: red;
  }
  input::placeholder {
      color: blue;
  }
  </style>
</head>
<body>
  <input type="text" placeholder="Banana" />
</body>
</html>

the layout is different in Gecko (left) and Servo (right):

screen shot 2018-01-18 at 11 23 13

@ferjm
Copy link
Member

@ferjm ferjm commented Jan 18, 2018

I believe Servo does not support the ::placeholder pseudo-element.

Actually, it seems that at least Stylo supports it, but it does not seem to be working properly. I'll investigate more.

@ferjm
Copy link
Member

@ferjm ferjm commented Jan 18, 2018

Apparently there's support for Gecko, but not for Servo, so I opened #19808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.