Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up fontconfig .gitignore #1956

Closed
jdm opened this issue Mar 21, 2014 · 4 comments
Closed

Fix up fontconfig .gitignore #1956

jdm opened this issue Mar 21, 2014 · 4 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 21, 2014

After building it in-tree, I now see this:

# Not currently on any branch.
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#   modified:   .gitignore
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#   m4/libtool.m4
#   m4/ltoptions.m4
#   m4/ltsugar.m4
#   m4/ltversion.m4
#   m4/lt~obsolete.m4

Let's correct that.

@khodzha
Copy link
Contributor

@khodzha khodzha commented Mar 22, 2014

@jdm what is building in-tree? I had that issue too, but after checkout make from %servo_root%/build doesn't produce these files anymore. edit: actually they are gitignored and since .gitignore isn't changed, they are ignored properly

@jdm
Copy link
Member Author

@jdm jdm commented Mar 22, 2014

We introduced the fontconfig submodule recently, so we build it as part of the build from our source tree now. That's what I mean by "building in-tree".

@khodzha
Copy link
Contributor

@khodzha khodzha commented Mar 23, 2014

@jdm I guess this issue is somehow fixed since now building doesn't change fontconfig's .gitignore -> no untracked content in fontconfig dir

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 9, 2014

@jdm, do you still see this? #2040 made git status clean for me, but what I had before was different to it could be a separate issue.

@jdm jdm closed this Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.