Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntermittent failure in /_mozilla/mozilla/css-paint-api/paint2d-image.html, /_mozilla/mozilla/css-paint-api/paint2d-filter.html #19631
Comments
|
Oh rats, is this caused by adding the timeout to paint worklets? It could be that the worklet isn't doing its job in the time allotted, which causes the failure. There easiest fix would be a parameter for how long to wait before timing out. There are probably better fixes though. |
|
++ for injecting the expected timeout when requesting a paint. I wonder though what happens to the 60fps requirement in this case. When a paint2d thread takes too long to paint an image, increasing the timeout to > 16ms will waste work, right? |
jdm
changed the title
|
[Back from winter break, catching up on backlog...] @yati-sagade yes, I'd expect large timeout values only to be used for things like wpt testcases. |
|
I see, then probably the timeout can be bumped for particular tests using the pref |
|
Indeed. |
Fixes servo#19631 Since the addition of timeouts to paint worklets, CSS paint API threads were failing intermittently because of the timeouts being fired. This is because the timeouts are quite tight, to account for the 60fps requirement. Bumping up the timeout threshold for these tests alone is the easiest solution.
|
@asajeffrey that seems to work ^^ |
CSS Paint API: Use a high timeout for worklet threads in tests Fixes #19631 Since the addition of timeouts to paint worklets, CSS paint API threads were failing intermittently because of the timeouts being fired. This is because the timeouts are quite tight, to account for the 60fps requirement. Bumping up the timeout threshold for these tests alone is the easiest solution. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because this changes config for a test. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19702) <!-- Reviewable:end -->
The testcase shows a blank page.