Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problems in the cookie implementation that hide test issues #19674

Open
jdm opened this issue Jan 2, 2018 · 5 comments
Open

Fix the problems in the cookie implementation that hide test issues #19674

jdm opened this issue Jan 2, 2018 · 5 comments
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Jan 2, 2018

web-platform-tests/wpt#8775 modified tests that were added in #11624. We should:

  • figure out why they were passing in Servo while every other browser failed them
  • add automated tests that specifically check those conditions, ensuring that other browsers pass them and Servo fails them
  • modify our implementation to pass the new tests
@jdm jdm added the A-network label Jan 2, 2018
@jdm
Copy link
Member Author

@jdm jdm commented Jan 2, 2018

Huh. We apparently don't run the cookies tests at all, and did not run them when when the test was added.

@jdm
Copy link
Member Author

@jdm jdm commented Jan 3, 2018

/cookies/path/match.html
------------------------
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: /
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: match.html
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: cookies
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: /cookies
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: /cookies/
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: /cookies/path/echo-cookie.html

These are the failures that exist on master.

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 3, 2018

With the patches applied on WPT upstream, the 2 remaining tests that fail are:

FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: match.html
FAIL `Set-Cookie` on /cookies/path/echo-cookie.html sets cookie with path: cookies
@pshaughn
Copy link
Member

@pshaughn pshaughn commented Jan 24, 2020

Are we still not running the cookies test directory?

@jdm
Copy link
Member Author

@jdm jdm commented Jan 24, 2020

Yeah, I forgot I filed this previous and filed #24869 last november.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.