Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove out-of-date FIXME comments from domimplementation.rs #19723

Closed
asajeffrey opened this issue Jan 8, 2018 · 3 comments
Closed

Remove out-of-date FIXME comments from domimplementation.rs #19723

asajeffrey opened this issue Jan 8, 2018 · 3 comments
Labels
A-content/script C-assigned E-easy I-cleanup

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jan 8, 2018

There are two FIXME comments in domimplementation.rs:

servo/components/script/dom/domimplementation.rs

Line 117 in 02f1864

// FIXME: https://github.com/mozilla/servo/issues/1522
and

servo/components/script/dom/domimplementation.rs

Line 186 in 02f1864

// FIXME: https://github.com/mozilla/servo/issues/1522
which refer to a closed issue #1522.

Both of these FIXME comments should be replaced by "The origin is already set".
@highfive
Copy link

@highfive highfive commented Jan 8, 2018

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@jdm jdm added the I-cleanup label Jan 8, 2018
@hindenbug
Copy link
Contributor

@hindenbug hindenbug commented Jan 8, 2018

@highfive: assign me
@highfive highfive added the C-assigned label Jan 8, 2018
@highfive
Copy link

@highfive highfive commented Jan 8, 2018

Hey @hindenbug! Thanks for your interest in working on this issue. It's now assigned to you!
@hindenbug hindenbug mentioned this issue Jan 8, 2018
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this issue Jan 9, 2018
@bors-servo
Auto merge of #19724 - hindenbug:19723-remove-fixme-comments, r=metajack
Loading status checks…
aa19930 
Remove out of date FIXME comments from domimplementation

<!-- Please describe your changes on the following line: -->
This removes out of date FIXME comments from `domimplementation.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19723

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this is a comment cleanup

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19724)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove out of date FIXME comments from domimplementation
4 participants
@jdm @hindenbug @asajeffrey @highfive
You can’t perform that action at this time.