Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmutation_test.sh fails due to a missing file or directory #19821
Labels
Comments
|
cc @aneeshusa |
bors-servo
added a commit
that referenced
this issue
Jan 27, 2018
Fix mutation test in CI by passing env vars correctly Originally, buildbot would try to directly execute `RUSTFLAGS=` as a binary since it was the first token in the command string, which won't work. Fix this by using the `env` command to set the environment variables, as there is currently no support for setting per-step environment variables in the `buildbot_steps.yml` file. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes should fix #19821 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they change the CI configuration <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19884) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jan 28, 2018
Fix mutation test in CI by passing env vars correctly Originally, buildbot would try to directly execute `RUSTFLAGS=` as a binary since it was the first token in the command string, which won't work. Fix this by using the `env` command to set the environment variables, as there is currently no support for setting per-step environment variables in the `buildbot_steps.yml` file. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes should fix #19821 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because they change the CI configuration <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19884) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It doesn't like the new invocation that resulted from the changes in #19806.