Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the define_css_keyword_enum! and add_impls_for_keyword_enum macros. #19827

Closed
emilio opened this issue Jan 22, 2018 · 5 comments
Closed

Remove the define_css_keyword_enum! and add_impls_for_keyword_enum macros. #19827

emilio opened this issue Jan 22, 2018 · 5 comments
Assignees
@nox
Labels
A-content/css C-assigned E-easy

Comments

@emilio
Copy link
Member

@emilio emilio commented Jan 22, 2018

There should be no need for them since we now derive Parse for keywords (7036cb0).

We should remove all the uses for those macros like 4abd1dc does. There are still a few though!

It's ok to remove them one by one, or to do all on the same PR (there aren't that many I think).
@emilio emilio added the E-easy label Jan 22, 2018
@highfive
Copy link

@highfive highfive commented Jan 22, 2018

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄
@alexfjw
Copy link
Contributor

@alexfjw alexfjw commented Jan 22, 2018

@highfive: assign me
@highfive
Copy link

@highfive highfive commented Jan 22, 2018

Hey @alexfjw! Thanks for your interest in working on this issue. It's now assigned to you!
@highfive highfive added the C-assigned label Jan 22, 2018
@nox
Copy link
Member

@nox nox commented Jan 30, 2018

I'm sorry, I did this in #19903, unaware of this issue.
@alexfjw
Copy link
Contributor

@alexfjw alexfjw commented Jan 30, 2018

No problem. Was a little busy the past week so I haven't really made much progress actually.
@nox nox mentioned this issue Jan 30, 2018
Merged
@nox nox self-assigned this Jan 31, 2018
bors-servo added a commit that referenced this issue Feb 1, 2018
@bors-servo
Auto merge of #19903 - servo:derive-all-the-things, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b4339ab 
Derive more Parse implementations (fixes #19827)

Fixes #19827.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19903)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox nox

Labels
A-content/css C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@nox @emilio @highfive @alexfjw
You can’t perform that action at this time.