Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DuckDuckGo divider not inline with text #19869

Open
atouchet opened this issue Jan 26, 2018 · 1 comment
Open

DuckDuckGo divider not inline with text #19869

atouchet opened this issue Jan 26, 2018 · 1 comment

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented Jan 26, 2018

URL: https://duckduckgo.com/?q=Servo&t=hw

Image of issue (Firefox top, Servo bottom):

DuckDuckGo

The divider between "Videos" and "Meanings" isn't inline with the text in Servo. Tested in Windows 10 with Browser.html.

@jdm jdm added the C-needs-test label Jan 26, 2018
@sviter
Copy link

@sviter sviter commented Jan 28, 2018

<!DOCTYPE html>
<style>
.zcm__sep--h:before {
 margin:0 7px;
 height:1em
}
.zcm__item,.zcm__sep--h {
 vertical-align:top;
 display:inline-block
}
.zcm__link {
 display:block;
 margin:0 7px;
 line-height:37px;
}
.zcm__sep--h {
 line-height:37px;
}
.zcm__sep--h:before {
 top:0.1em
}
.sep--before:before {
 border-left:1px solid #d0d0d0;
 display:inline-block;
 position:relative;
}
.sep--before:before {
 content:""
}
</style>
<ul class="zcm__menu zcm__dynamic has-zci" id="duckbar_new">
    <span id="duckbar_dynamic_sep" class="zcm__sep--h sep--before"></span>
    <li class="zcm__item"><a data-zci-link="meanings" class="zcm__link  js-zci-link  js-zci-link--meanings" href="#">Text</a></li>
</ul>

If I delete vertical-align:top; it's not affect FF but fix issue for Servo

@paulrouget paulrouget mentioned this issue Feb 9, 2018
16 of 24 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.