Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle `None` in `script::devtools::determine_auto_margins` #19887

Open
jonleighton opened this issue Jan 28, 2018 · 1 comment
Open

Handle `None` in `script::devtools::determine_auto_margins` #19887

jonleighton opened this issue Jan 28, 2018 · 1 comment

Comments

@jonleighton
Copy link
Contributor

@jonleighton jonleighton commented Jan 28, 2018

See @emilio's comment:

I just noticed this... This unwrap may not be safe, I don't think anything guarantees that the element is not in a display: none subtree... Though it was a pre-existing bug, and I don't know where this code runs.

It remains to be seen if the unwrap is actually a problem, but from a cursory look at the code I think it probably is. Probably inspecting a node via devtools which is in a display: none subtree will trigger the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.