Move some font code around #20047
Merged
Move some font code around #20047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
highfive
added
the
S-awaiting-review
emilio
approved these changes
Feb 14, 2018
There was a problem hiding this comment.
rs=me
Just for the record, the KeywordInfo change is because of:
15:20 <emilio> nox: why did keywordinfo become generic?
15:21 <nox> emilio: Because I plan to make NonNegativeLength animate as Length.
15:22 <nox> emilio: TL;DR if I want to continue #20040 I need to clean a dozen rabbit holes.
|
TravisCI shows several build errors. |
jdm
added
S-needs-code-changes
|
Oops, I only ran |
nox
force-pushed
the
derive-all-the-things
branch
from
04155bc
to
ee8690a
Compare
highfive
added
S-awaiting-review
emilio
approved these changes
Feb 15, 2018
|
@bors-servo r=emilio |
|
📌 Commit ee8690a has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 15, 2018
Move some font code around The only notable change is that KeywordInfo is now generic. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20047) <!-- Reviewable:end -->
|
💔 Test failed - linux-dev |
highfive
added
S-tests-failed
nox
force-pushed
the
derive-all-the-things
branch
from
ee8690a
to
d8c43ac
Compare
highfive
added
the
S-awaiting-review
|
@bors-servo r=emilio |
|
📌 Commit d8c43ac has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Feb 15, 2018
Move some font code around The only notable change is that KeywordInfo is now generic. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20047) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only notable change is that KeywordInfo is now generic.
This change is