servo / servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining WPT failures for element.innerText #20060

Open

ferjm opened this issue Feb 16, 2018 · 0 comments

Labels

A-content/dom

Member

ferjm commented Feb 16, 2018 •

edited

There are still several tests failing for the getter of element.innerText.

Check: https://github.com/servo/servo/blob/master/tests/wpt/metadata/innerText/getter.html.ini

The table related ones are likely because of missing support here. The others require further investigation.

Blockers:

Support visibility: collapse #20142
Properly implement step 3 of the inner text collection steps algorithm #20159
Ignore descendants nodes of replace elements during inner text collection steps #20161

jdm added the A-content/dom label

ferjm mentioned this issue

Fix some innerText getter WPTs #20125

Open

3 of 3 tasks complete

bors-servo added a commit that referenced this issue


        Auto merge of #20125 - ferjm:innertext.table, r=<try>

2f06c6c

Identify if a node is the last table row or cell for innerText implem…

…entation

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

This completes steps 6 and 7 from the [inner text collection steps](https://html.spec.whatwg.org/multipage/dom.html#inner-text-collection-steps). Unfortunately, it does not seem to fix the failing tests related to tables mentioned in #20060.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20125)
<!-- Reviewable:end -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.