Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPinch to zoom support #20109
Closed
Pinch to zoom support #20109
Assignees
Labels
Comments
|
Isn't that the job of the embedder to track the TouchId and do the zooming? |
|
It's hard to let the embedder do that because the behavior can depend on whether preventDefault() was called on the touchstart event. But actually there seems to be support in |
|
It should work like key events. Embedder send touch events to Servo, if Servo send them back, the embedder call the zoom functions. |
bors-servo
added a commit
that referenced
this issue
May 24, 2018
Basic pinch zoom handling r? glennw Basic fix for #20387 and #20109. Note: Without calling `generate_frame` when updating Webrender's pinch zoom level, rendering doesn't happen reliably during/after a pinch zoom gesture. I'm not sure whether this is the correct way to fix that or not. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20749) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 24, 2018
Basic pinch zoom handling r? glennw Basic fix for #20387 and #20109. Note: Without calling `generate_frame` when updating Webrender's pinch zoom level, rendering doesn't happen reliably during/after a pinch zoom gesture. I'm not sure whether this is the correct way to fix that or not. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20749) <!-- Reviewable:end -->
|
Fixed by #20749. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When an embedder sends a sequence of touch events such as:
TouchEventType::Down, one or more TouchEventType::Move, TouchEventType::Up these are correctly used to pan the page and/or synthetized a click.
However when there are multiple TouchId tracked, they are not taken into account to provide a pinch to zoom functionality.