text flow / layout issues on OSX

[cpdean]

I tried building from source on master but I got some interesting issues

I decided I probably built it wrong, so I downloaded the nightly build from the project page and when I open the .app file I have similar symptoms:

I'm on osx sierra ( 10.12.6 (16G1212) ) on a 13 inch 2017 macbook pro.

[emilio]

cc @glennw, maybe OSX driver bug?

[jdm]

Yeah, I can't reproduce this on my local build on macOS Sierra on a 2015 macbook pro.

[emilio]

This looks a lot like https://bugzilla.mozilla.org/show_bug.cgi?id=1444076

[kvark]

Should be "fixed" by WR update including servo/webrender#2499

[cpdean]

@kvark I'm still having the same issue as before:

I did a git pull followed by a clean, build, and opened with the newly-built binary:

./mach clean
...
./mach build --dev
...
- ❯❯❯ ./mach run https://www.reddit.com/r/rust/comments/82u3bm/servo_is_supposed_to_do_this_right/
Error running module
reddit.js
:
TypeError: n.fillText is not a function
Error sending debug logs to server:
parsererror
;
SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data
Error during reddit-init.js init
TypeError: n.fillText is not a function
2018-03-09 11:16:47.256 servo[21356:600227] IMKInputSession presentFunctionRowItemTextInputViewWithEndpoint:completionHandler: : [self textInputContext]=0x0 *NO* NSRemoteViewController to client, NSError=Error Domain=NSCocoaErrorDomain Code=4099 "The connection from pid 0 was invalidated from this process." UserInfo={NSDebugDescription=The connection from pid 0 was invalidated from this process.}, com.apple.inputmethod.EmojiFunctionRowItem
Error sending debug logs to server:
parsererror
;
SyntaxError: JSON.parse: unexpected end of data at line 1 column 1 of the JSON data

Am I doing something wrong to test the 'fix' from webrenderer?

[kvark]

@cpdean interesting. I can see that Servo's cargo.lock has WR version that includes the "fix".
Perhaps, the bisection pointed to the wrong change? @staktrace
I wasn't able to reproduce it, hence I myself can't confirm if the revert fixes anything.

[staktrace]

I verified the revert fixed things on the Gecko try builds.

[cpdean]

I've updated osx/macos to high sierra, 10.13.3 (17D47).

After re-installing all the xcode stuff to get rust builds working again, I still have the same issue. I've tested with both a --dev and --release build.

How do I debug what's going on here? I'm not sure how to compare what my build is doing versus other's who aren't experiencing this issue.

edit: my nightly is pretty old, going to experiment with different versions of rustc:

- ❯❯❯ rustc --version
rustc 1.25.0-nightly (15a1e2844 2018-01-20)

edit: okay nvm not sure what else to try

[kvark]

@staktrace since you had the original issue In Gecko, could you try checking the Servo to see if the issue is visible there?

[staktrace]

I tried the macOS build from download.servo.org and I can reproduce the issue as well. I'm on macOS 10.13.3, with a Intel Iris Plus Graphics 650 1536 MB graphics card.

[kvark]

@staktrace could you record a capture and provide something for us to investigate please?

[staktrace]

@kvark How do I get a capture in servo without doing a local build?

[kvark]

@staktrace I was thinking about the old binary recorder, which can be enabled in Servo by passing -Z wr-record

[staktrace]

Ah, here's a recording then. I just started servo with -Z wr-record and then closed it. The default start page had the funky text so presumably the recording should have it.
wr-record.bin.gz

[kvark]

@staktrace thanks! We'll need to know the WR revision here and ultimately convert it to a "real" capture (by hitting "C" within wrench when replaying it).

[staktrace]

@kvark It's whatever version of WR was in the March 12 servo-latest.dmg.

[jdm]

That would be 6611df9fdf930db4fb93a00ce2c2d3163c0bb1a1.

[jdm]

Nevermind, it should be 6dea428a429cb6410949c14279e115122f74c501.

[kvark]

I'm not able to replay the binary capture with either of those revisions :( WR binary reader only sees a single black frame.

[kvark]

Interestingly, both @staktrace and @cpdean appear to have Iris 650 video, and I can't reproduce it on Iris 550 video (apparently, OS version is less relevant here). I'll try to find another machine to repro.

[cpdean]

@kvark you are correct, my laptop has this gpu: Intel Iris Plus Graphics 650 1536 MB

[kvark]

I got a MBP 2017 with Iris 650, not able to reproduce the issue with latest Servo build (downloaded from download.servo.org). @cpdean is it still an issue for you?

[cpdean]

Both the latest build on download.servo.org works for me, as does a fresh pull on master (1ae5715) with a clean build:

./mach clean && ./mach build --dev && ./mach run https://www.reddit.com/r/rust/comments/82u3bm/servo_is_supposed_to_do_this_right/

Whatever happened, it's now resolved. Thanks everyone!