Extract text emphasis style

[NeverHappened]

Extracted the text-emphasis-style property out of the inherited_text.mako.rs.
This is a part of #19015

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• ./mach cargo-geckolib check does not report any errors
• These changes fix Move text-emphasis-style outside of mako #19940 (github issue number if applicable).

• These changes do not require tests because it's a refactoring

---

This change is 

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

[highfive]

Heads up! This PR modifies the following files:

• @bholley: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/text.rs and 2 more
• @canaltinova: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/text.rs and 2 more
• @emilio: components/style/properties/longhand/inherited_text.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/shorthand/inherited_text.mako.rs, components/style/values/specified/mod.rs, components/style/values/computed/text.rs and 2 more

[highfive]

Warning

• These commits modify style code, but no tests are modified. Please consider adding a test!

[upsuper]

"character" is a bit ambiguous here, because "character" in CSS may have different meaning than that in Rust. It should be "grapheme cluster" instead for better exactness. One may think we can use char instead if there is only one "character" being used, which is not true, because a grapheme cluster can well include multiple chars.

[NeverHappened]

Thanks for the explanation

[upsuper]

Reviewed 7 of 7 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

---

components/style/properties/shorthand/inherited_text.mako.rs, line 36 at r1 (raw file):

            Ok(expanded! {
                text_emphasis_color: unwrap_or_initial!(text_emphasis_color, color),
                text_emphasis_style: unwrap_or_initial!(text_emphasis_style, style), // TODO: what?

What's the TODO for?

---

components/style/values/computed/mod.rs, line 78 at r1 (raw file):

pub use self::table::XSpan;
pub use self::text::{InitialLetter, LetterSpacing, LineHeight, MozTabSize};
pub use self::text::{TextAlign, TextOverflow, WordSpacing, TextEmphasisStyle};

TextEmphasisStyle should be put between TextAlign and TextOverflow.

---

components/style/values/computed/text.rs, line 18 at r1 (raw file):

use values::generics::text::MozTabSize as GenericMozTabSize;
use values::generics::text::Spacing;
use values::specified::text::{TextOverflowSide, TextDecorationLine, FillMode, ShapeKeyword};

Could you order it alphabetically?

---

components/style/values/computed/text.rs, line 163 at r1 (raw file):

#[derive(Clone, Debug, MallocSizeOf, PartialEq, ToCss)]
pub struct KeywordValue {

The comment for specified value applies here as well.

---

components/style/values/specified/text.rs, line 530 at r1 (raw file):

#[derive(Clone, Debug, MallocSizeOf, PartialEq, ToCss)]
pub enum KeywordValue {

This should be TextEmphasisKeywordValue or something like that. I don't think it is correct to use KeywordValue as name for a type just for text-emphasis in module text.

Alternatively, you can probably create a nested module to wrap all these types in.

---

components/style/values/specified/text.rs, line 555 at r1 (raw file):

#[derive(Clone, Copy, Debug, MallocSizeOf, Parse, PartialEq, ToCss)]
pub enum FillMode {

Same issue here.

---

components/style/values/specified/text.rs, line 561 at r1 (raw file):

#[derive(Clone, Copy, Debug, Eq, MallocSizeOf, Parse, PartialEq, ToCss)]
pub enum ShapeKeyword {

And here.

---

Comments from Reviewable

[upsuper]

Thanks for your contribution! Please address the review comments.

[NeverHappened]

Fixed the issues with naming and imports order

[upsuper]

@bors-servo r+

Thanks!

[bors-servo]

📌 Commit a1dd888 has been approved by upsuper

[bors-servo]

⌛ Testing commit a1dd888 with merge aa8fb3a...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: upsuper
Pushing aa8fb3a to master...