Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport building script on Arch Linux #20268
Closed
Labels
Comments
|
It'd be good to support build script on arch ooto. Mind if I shoot small PR for it? @FallingSnow (only if you don't have plan to tackle this) |
|
By all means, please. I have too many other obligations to submit a PR otherwise I would have already :) |
|
@FallingSnow thanks, let me try to stab on this. |
|
@highfive : assign me |
|
Hey @kwonoj! Thanks for your interest in working on this issue. It's now assigned to you! |
bors-servo
added a commit
that referenced
this issue
Mar 13, 2018
build(cmake): detect python binary for specified version <!-- Please describe your changes on the following line: --> This PR aims to address #20268, by updating cmake definition to lookup python binary to use. Instead of directly asking `python` binary, this PR uses `${PYTHON_EXECUTABLE}` to lookup desired python binary where applicable. This PR was locally tested on win32 / mac / arch linux via `mach build --dev`, so far local testing shows no build failure regressions, not sure if this is sufficient test. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20268 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because _it's build script update_ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20290) <!-- Reviewable:end -->
pandusonu2
added a commit
to pandusonu2/servo
that referenced
this issue
Mar 15, 2018
- closes servo#20268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Arch Linux sets
pythonto python 3 andpython2to python 2.Script's CMakeLists.txt hard codes the python command.
servo/components/script/CMakeLists.txt
Line 64 in 53d9ca1
In order to select the correct python version
should be added to the top of the file and all python commands should be replaced with
${PYTHON_EXECUTABLE}so the above reads
P.S. This is supported by the minimum cmake version 2.6