Passing --nocapture to test-unit doesn't work

[jdm]

./mach test-unit -p profile --nocapture yields:

error: Unknown flag: '--nocapture'

Usage:
    cargo test [options] [TESTNAME] [--] [<args>...]

[highfive]

cc @wafflespeanut

[SimonSapin]

Try adding -- to separate test-program args from cargo args. Or maybe twice to also separate cargo args from mach args.

[jdm]

Neither ./mach test-unit -p profile -- --nocapture nor ./mach test-unit -p profile -- -- --nocapture made a difference.

[jdm]

Although maybe that's a change that needs to be made to the invocation of cargo from the mach command instead.

[SimonSapin]

I’ve just looked at the code, test-unit does not accept arbitrary arguments or pass them through to cargo. Maybe it should, but in the meantime you can probably use ./mach cargo test or even cargo test.

[jdm]

Sure, but test-unit does accept an explicit --nocapture argument, so it's surprising that it's broken.

[SimonSapin]

Oh I missed that, sorry.

It does appear to work for me though:

$ ./mach test-unit -p profile --nocapture -v
[…]
     Running `/home/simon/servo/target/debug/deps/profile_tests-131711d7e4e31353 --nocapture`
[…]