Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upservo-linux-cross2 suddenly didn't like mozangle #20281
Comments
jdm
commented
Mar 12, 2018
|
cc @aneeshusa |
|
What’s the GCC version? |
|
Part of the output that seems most relevant:
mozangle uses |
|
What PR was this one? http://build.servo.org/builders/android/builds/11017 is green on servo-linux-cross2 after this issue was opened. |
|
It was observed in #20273. |
|
This just happened on servo-mac2 as well in #20290. |
|
Also on servo-mac5 on the same merge attempt. |
|
Strangely in the mac builds logs |
|
Stackoverflow suggested that using CC=gcc-5 and CXX=g++-5 may fix this. We used to use those when we depended on gecko-media: f46fbe4 |
|
cc-rs’s https://github.com/alexcrichton/cc-rs/blob/1.0.6/src/lib.rs#L396-L447 It may be worth printing the result of |
Use a newer GCC on mac for mozangle builds. This is an attempt to address #20281 which is hitting our mac builders relatively frequently. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20297) <!-- Reviewable:end -->
|
A more recent compiler is probably good, but if cc-rs is buggy (flags being intermittently incorrectly considered as unsupported?) we should determine that and report it upstream. |
|
The command line for the mac failures shows that -std=gnu++11 is being passed when the failures occur. |
|
Ok, so here's a peculiarity. In the log with a failure, the actual file that is failing does not include -std=gnu++11 while lots of other files do have it. When I do a local build, all the files include the flag. |
Update mozangle to 0.1.6. This will get rid of the frequent intermittent build failure in mozangle. Fixes #20281. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20309) <!-- Reviewable:end -->