Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport percentage height #2029
Closed
Labels
Comments
|
Same in |
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Apr 3, 2014
This is necessary but not sufficient for servo#2029. A bug fix in the previous commit "broke" Acid 2 because that bug was hiding this one. This makes Acid 2 pass again.
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Apr 3, 2014
See http://dev.w3.org/csswg/css2/visudet.html#propdef-height This is necessary but not sufficient for servo#2029. A bug fix in the previous commit "broke" Acid 2 because that bug was hiding this one. This makes Acid 2 pass again.
|
There is an errata on CSS2 on this: http://www.w3.org/Style/css2-updates/REC-CSS2-20110607-errata.html#s.10.5a this is not reflected in the ED as of this writing, even though it should be :( |
pcwalton
added a commit
to pcwalton/servo
that referenced
this issue
Apr 3, 2014
See http://dev.w3.org/csswg/css2/visudet.html#propdef-height This is necessary but not sufficient for servo#2029. A bug fix in the previous commit "broke" Acid 2 because that bug was hiding this one. This makes Acid 2 pass again.
Closed
jkim-julie
pushed a commit
to jkim-julie/servo
that referenced
this issue
Sep 19, 2014
Fixes servo#2029
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #1988,
BlockFlow::assign_height_block_basehas code like this:Noneshould instead beSome(containing_block_height)when that height can be resolved at this point. That is, it’s notautonor a percentage that refers to something that can not be resolved at this point.This probably involves propagating non-auto height down the tree in an earlier top-down pass.
See in http://dev.w3.org/csswg/css2/visudet.html#propdef-height