Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support percentage height #2029

Closed
SimonSapin opened this issue Apr 3, 2014 · 2 comments
Closed

Support percentage height #2029

SimonSapin opened this issue Apr 3, 2014 · 2 comments
Assignees

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 3, 2014

As of #1988, BlockFlow::assign_height_block_base has code like this:

let mut candidate_height_iterator = CandidateHeightIterator::new(
    fragment.style(), None);

None should instead be Some(containing_block_height) when that height can be resolved at this point. That is, it’s not auto nor a percentage that refers to something that can not be resolved at this point.

This probably involves propagating non-auto height down the tree in an earlier top-down pass.

See in http://dev.w3.org/csswg/css2/visudet.html#propdef-height

@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Apr 3, 2014

Same in BlockFlow::assign_height_float, but BlockFlow::calculate_abs_height_and_margins looks already correct.

SimonSapin added a commit to SimonSapin/servo that referenced this issue Apr 3, 2014
This is necessary but not sufficient for servo#2029.

A bug fix in the previous commit "broke" Acid 2 because that bug was hiding
this one. This makes Acid 2 pass again.
SimonSapin added a commit to SimonSapin/servo that referenced this issue Apr 3, 2014
See http://dev.w3.org/csswg/css2/visudet.html#propdef-height

This is necessary but not sufficient for servo#2029.

A bug fix in the previous commit "broke" Acid 2 because that bug was hiding
this one. This makes Acid 2 pass again.
@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Apr 3, 2014

There is an errata on CSS2 on this: http://www.w3.org/Style/css2-updates/REC-CSS2-20110607-errata.html#s.10.5a this is not reflected in the ED as of this writing, even though it should be :(

pcwalton added a commit to pcwalton/servo that referenced this issue Apr 3, 2014
See http://dev.w3.org/csswg/css2/visudet.html#propdef-height

This is necessary but not sufficient for servo#2029.

A bug fix in the previous commit "broke" Acid 2 because that bug was hiding
this one. This makes Acid 2 pass again.
@mbrubeck mbrubeck self-assigned this Sep 14, 2014
@brson brson mentioned this issue Sep 14, 2014
42 of 56 tasks complete
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 15, 2014
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 16, 2014
jkim-julie pushed a commit to jkim-julie/servo that referenced this issue Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.