Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose webrender debugger as a feature in components/servo #20324
Labels
Comments
Moggers
changed the title
|
Yes; a pull request to do that would be fine. |
bors-servo
added a commit
that referenced
this issue
Mar 19, 2018
Re-expose webrender debugger feature in components/servo <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors ``` Checking files for tidiness... ./Cargo.lock:1: duplicate versions for package `base64` The following packages depend on version 0.3.1 from 'crates.io': webrender The following packages depend on version 0.6.0 from 'crates.io': hyper net script webdriver_server ./Cargo.lock:1: duplicate versions for package `bytes` The following packages depend on version 0.3.0 from 'crates.io': ws The following packages depend on version 0.4.6 from 'crates.io': ws ./Cargo.lock:1: duplicate versions for package `ws` The following packages depend on version 0.6.0 from 'crates.io': debugger The following packages depend on version 0.7.3 from 'crates.io': webrender ./Cargo.lock:1: duplicate versions for package `image` The following packages depend on version 0.17.0 from 'crates.io': webrender The following packages depend on version 0.18.0 from 'crates.io': compositing net_traits script webdriver_server ``` What should I do about this? - [x] These changes fix #20324 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because: Not sure actually, do I need to write integration tests to make sure it builds with the feature enabled? <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20328) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Mar 19, 2018
Re-expose webrender debugger feature in components/servo <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors ``` Checking files for tidiness... ./Cargo.lock:1: duplicate versions for package `base64` The following packages depend on version 0.3.1 from 'crates.io': webrender The following packages depend on version 0.6.0 from 'crates.io': hyper net script webdriver_server ./Cargo.lock:1: duplicate versions for package `bytes` The following packages depend on version 0.3.0 from 'crates.io': ws The following packages depend on version 0.4.6 from 'crates.io': ws ./Cargo.lock:1: duplicate versions for package `ws` The following packages depend on version 0.6.0 from 'crates.io': debugger The following packages depend on version 0.7.3 from 'crates.io': webrender ./Cargo.lock:1: duplicate versions for package `image` The following packages depend on version 0.17.0 from 'crates.io': webrender The following packages depend on version 0.18.0 from 'crates.io': compositing net_traits script webdriver_server ``` What should I do about this? - [x] These changes fix #20324 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because: Not sure actually, do I need to write integration tests to make sure it builds with the feature enabled? <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20328) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would it be possible to expose a crate feature in components/servo that just re-exposes webrender's debugger?