Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DOMMatrixReadOnly and DOMMatrix constructors for typed arrays #20349

Closed
jdm opened this issue Mar 19, 2018 · 2 comments
Closed

Implement DOMMatrixReadOnly and DOMMatrix constructors for typed arrays #20349

jdm opened this issue Mar 19, 2018 · 2 comments
Labels
A-content/dom C-assigned E-less easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 19, 2018 •
edited

Now that #20267 has merged we are able to implement the fromFloat32Array and fromFloat64Array static methods, along with toFloat32Array and toFloat64Array.

Spec: https://drafts.fxtf.org/geometry-1/#dom-dommatrixreadonly-fromfloat32array
Code: components/script/dom/webidls/DOMMatrixReadOnly.webidl, components/script/dom/dommatrixreadonly.rs, components/script/dom/webidls/DOMMatrix.webidl, components/script/dom/dommatrix.rs
Tests: ./mach test-wpt tests/wpt/web-platform-tests/css/geometry (there should be new passing tests)
@jdm jdm changed the title Implement DOMMatrixReadOnly constructors for typed arrays Implement DOMMatrixReadOnly and DOMMatrix constructors for typed arrays Mar 19, 2018
@christianpoveda
Copy link
Contributor

@christianpoveda christianpoveda commented Mar 23, 2018

@highfive assign me
@highfive
Copy link

@highfive highfive commented Mar 23, 2018

Hey @christianpoveda! Thanks for your interest in working on this issue. It's now assigned to you!
@highfive highfive added the C-assigned label Mar 23, 2018
@christianpoveda christianpoveda mentioned this issue Mar 23, 2018
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Mar 24, 2018
@bors-servo
Auto merge of #20405 - christianpoveda:issue_20349, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2d78964 
Add constructors for typed arrays in DOMMatrix and DOMMatrixReadOnly

<!-- Please describe your changes on the following line: -->

- DOMMatrix now have the functions: FromFloat32Array, FromFloat64Array.
- DOMMatrixReadOnly now have the functions: FromFloat32Array, FromFloat64Array, ToFloat32Array, ToFloat64Array.

r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20349 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20405)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-less easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add constructors for typed arrays in DOMMatrix and DOMMatrixReadOnly
3 participants
@jdm @highfive @christianpoveda
You can’t perform that action at this time.