Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAcid2 not pixel perfect #2035
Open
Acid2 not pixel perfect #2035
Labels
Comments
|
Yes, layers doesn't currently do pixel snapping. This shows up on other sites as well when scrolling. Needs to be addressed as part of the layers refactoring. |
SimonSapin
added a commit
to SimonSapin/servo
that referenced
this issue
Jul 1, 2014
The rendering is incorrect, but this should help catch further regressions.
The test is modified to add the following CSS:
.intro { display: none }
html #top { margin-top: 0 }
This works around the lack of layer pixel snapping. (See servo#2035)
The reference is modified to match the current rendering of the test:
* Rows 1, 2 (forehead), 4, and 5 (eyes) are missing.
* The yellow background in row 3 overflows by 1px at the bottom.
* The top-right and bottom-left borders of the nose are 1px to high.
* Row 12’s height is 3px more than it should be.
* Rows 13 and 14’s positions are 4px lower than they should be.
(See http://www.webstandards.org/action/acid2/guide/ for row numbers.)
The nose issue seems be related to rounding vs truncating
when pixel-snapping borders, but this is only a guess.
Adding `.chin div { font-size: 3px }` works around the chin issue
(rows 12 to 14) for reasons that escape me yet.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is Gimp’s Difference blend mode of
With commit fe1615b.
The main problem seems to be that scrolling to
#topleaves us at a non-integer pixel position, causing anti-aliasing issues. The test because almost pixel-perfect (except the nose that’s 1px off and the eyes that seem to round alpha blending differently than the reference) if I remove this part of the test, with these additional style rules: