Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArrayBufferView in getRandomValues API #20350

Closed
jdm opened this issue Mar 19, 2018 · 2 comments
Closed

Use ArrayBufferView in getRandomValues API #20350

jdm opened this issue Mar 19, 2018 · 2 comments
Labels
A-content/dom C-assigned E-less easy I-cleanup

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 19, 2018

Now that #20267 has merged, we can remove our workaround for the getRandomValues API and use the proper type in the WebIDL instead. This will require cleanup similar to #20342.

Code: components/script/dom/webidls/Crypto.webidl, components/script/dom/crypto.rs
Tests: ./mach test-wpt tests/wpt/web-platform-tests/WebCryptoAPI
@christianpoveda
Copy link
Contributor

@christianpoveda christianpoveda commented Mar 21, 2018

@highfive assign me
@highfive highfive added the C-assigned label Mar 21, 2018
@highfive
Copy link

@highfive highfive commented Mar 21, 2018

Hey @christianpoveda! Thanks for your interest in working on this issue. It's now assigned to you!
@christianpoveda christianpoveda mentioned this issue Mar 22, 2018
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Mar 22, 2018
@bors-servo
Auto merge of #20389 - christianpoveda:issue_20350, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e5b606f 
getRandomValues uses ArrayBufferView now

<!-- Please describe your changes on the following line: -->

- Changed the `Crypto.webidl` file to allow getRandomValues to recieve an ArrayBufferView as input
- Removed unnecesary checks from `crypto.rs` and did the necessary changes to match the `webidl` changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20350 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20389)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-less easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

getRandomValues uses ArrayBufferView now
3 participants
@jdm @highfive @christianpoveda
You can’t perform that action at this time.