Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInvestigate if GetTexParameter should fail if 0 is returned. #20372
Labels
Comments
|
This is not the case anymore: fn get_tex_parameter(gl: &gl::Gl,
target: u32,
pname: u32,
chan: WebGLSender<i32> ) {
let result = gl.get_tex_parameter_iv(target, pname);
chan.send(result).unwrap();
}https://github.com/servo/servo/blob/master/components/canvas/webgl_thread.rs#L1084-L1090 |
|
It was refactored, but the check was left intact: servo/components/script/dom/webglrenderingcontext.rs Lines 1408 to 1414 in e06f0d3 If it's not needed, the whole thing can be simplified to |
Merged
bors-servo
added a commit
that referenced
this issue
May 7, 2018
Webgl fixes <!-- Please describe your changes on the following line: --> Add gl.getParameter() support for webgl unpack settings, and remove some unreachable and incorrect error-generation code --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20372 - [x] These changes fix #20553 - [x] These changes fix #20554 <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20754) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 7, 2018
Webgl fixes <!-- Please describe your changes on the following line: --> Add gl.getParameter() support for webgl unpack settings, and remove some unreachable and incorrect error-generation code --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20372 - [x] These changes fix #20553 - [x] These changes fix #20554 <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20754) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 18, 2018
Webgl fixes <!-- Please describe your changes on the following line: --> Add gl.getParameter() support for webgl unpack settings, and remove some unreachable and incorrect error-generation code --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20372 - [x] These changes fix #20553 - [x] These changes fix #20554 <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20754) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 18, 2018
Webgl fixes <!-- Please describe your changes on the following line: --> Add gl.getParameter() support for webgl unpack settings, and remove some unreachable and incorrect error-generation code --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20372 - [x] These changes fix #20553 - [x] These changes fix #20554 <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20754) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
May 19, 2018
Webgl fixes <!-- Please describe your changes on the following line: --> Add gl.getParameter() support for webgl unpack settings, and remove some unreachable and incorrect error-generation code --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20372 - [x] These changes fix #20553 - [x] These changes fix #20554 <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20754) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
GetTexParameterfails if 0 is returned, but none of the specs specify that.Specs:
WebGL
GLES
servo/components/canvas/webgl_thread.rs
Lines 1075 to 1077 in 730bd5e
servo/components/script/dom/webglrenderingcontext.rs
Lines 1362 to 1364 in 730bd5e