Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiateJSToNativeConversion should work directly with JSToNativeConversion class #20403

Open
jdm opened this issue Mar 23, 2018 · 1 comment
Open

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 23, 2018

Instead of lots of code taking the result of getJSToNativeConversion and extracting the members of the JSToNativeConversion class to pass as arguments to instantiateJSToNativeConversion, it will be easier to modify how those methods work if instantiateJSToNativeConversion takes the class directly as an argument. This should allow cleaning up the callers that pass the isAutoRooted argument, since that can be computed by getJSToNativeConversion and stored in the class. This should allow more consistent handling of types that should be stored in a CustomAutoRoot value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.