Go back/forward keybinding should not traverse history on key release

[cbrewster]

When using the go forward/back keybindings to traverse the session history, the constellation is flooded with traversal messages as long as the key binding is held down. We should just send a single message for a key press or at least have an interval of a second or so between subsequent messages.

I am using macOS, not sure if this is the case on other platforms.

[paulrouget]

I think it's not repeating too fast. But we get 2 events for key down and key up. So the event is sent twice.

[paulrouget]

Note to whoever might work on this: if we send reload/goForward/… messages on KeyState::Pressed, we need to figure out if we need to send key window events to Servo on KeyState::Released key events.

[cbrewster]

We should only send the Navigation event on key pressed or key repeated and not on key released.
To fix this, check the state in both these branches and make sure it is not equal to key released.

servo/ports/servo/browser.rs

Lines 123 to 134 in 07dd37a

	(CMD_OR_ALT, None, Key::Right) | (KeyModifiers::NONE, None, Key::NavigateForward) => {
	if let Some(id) = self.browser_id {
	let event = WindowEvent::Navigation(id, TraversalDirection::Forward(1));
	self.event_queue.push(event);
	}
	}
	(CMD_OR_ALT, None, Key::Left) | (KeyModifiers::NONE, None, Key::NavigateBackward) => {
	if let Some(id) = self.browser_id {
	let event = WindowEvent::Navigation(id, TraversalDirection::Back(1));
	self.event_queue.push(event);
	}
	}

[highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

[piotr-szpetkowski]

Hi.
I don't have much experience in Rust, but it seems like an easy thing to do, so I'll try to tackle it.

@highfive: assign me

[highfive]

Hey @piotr-szpetkowski! Thanks for your interest in working on this issue. It's now assigned to you!

[paulrouget]

#21250 fixed this.