Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have cssparser::AtRuleParser pass SourceLocation via param of parse_block / rule_without_block #20527

Open
upsuper opened this issue Apr 4, 2018 · 0 comments
Open

Have cssparser::AtRuleParser pass SourceLocation via param of parse_block / rule_without_block #20527

upsuper opened this issue Apr 4, 2018 · 0 comments

Comments

@upsuper
Copy link
Member

@upsuper upsuper commented Apr 4, 2018

Nowadays, almost every variant of AtRuleBlockPrelude / AtRuleNonBlockPrelude contains a field for SourceLocation. (CounterStyle will get it in bug 1449068). I think it makes sense to just move all those fields into a parameter of parse_block and rule_without_block.

This would need a breaking version bump of cssparser.

cc @SimonSapin
@upsuper upsuper mentioned this issue Jun 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@upsuper
You can’t perform that action at this time.