Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with custom Webrender #20609

Closed
hgallagher1993 opened this issue Apr 10, 2018 · 1 comment
Closed

Build error with custom Webrender #20609

hgallagher1993 opened this issue Apr 10, 2018 · 1 comment

Comments

@hgallagher1993
Copy link
Contributor

@hgallagher1993 hgallagher1993 commented Apr 10, 2018

Trying to build Servo with custom Webrender and Webrender_Api results in 2 build errors.

error[E0432]: unresolved import `webrender_api::ScrollEventPhase`
  --> components/compositing/compositor.rs:39:37
   |
39 | use webrender_api::{LayoutVector2D, ScrollEventPhase, ScrollLocation};
   |                                     ^^^^^^^^^^^^^^^^ no `ScrollEventPhase` in the root

error[E0204]: the trait `Copy` may not be implemented for this type
   --> components/compositing/compositor.rs:193:17
    |
193 | #[derive(Clone, Copy)]
    |                 ^^^^
...
202 |     phase: ScrollEventPhase,
    |     ----------------------- this field does not implement `Copy`

error: aborting due to 2 previous errors

Looks like ScrollEventPhase was removed in servo/webrender#2629.

@Eijebong
Copy link
Member

@Eijebong Eijebong commented Apr 10, 2018

Yeah webrender hasn't been synced since then. (Going to do it with #20497)

Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo added a commit that referenced this issue Apr 10, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo added a commit that referenced this issue Apr 10, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo added a commit that referenced this issue Apr 11, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 17, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 17, 2018
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo added a commit that referenced this issue Apr 17, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 20, 2018
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 20, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
nox added a commit that referenced this issue Apr 25, 2018
Fixes #20609
nox added a commit that referenced this issue Apr 25, 2018
Fixes #20609
@nox nox mentioned this issue Apr 25, 2018
nox added a commit that referenced this issue Apr 25, 2018
Fixes #20609
bors-servo added a commit that referenced this issue Apr 25, 2018
Update Webrender

Fixes #20609

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20690)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Apr 27, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 1, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 1, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 1, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 2, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 2, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 2, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 2, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue May 24, 2018
bors-servo added a commit that referenced this issue May 24, 2018
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 24, 2018
…onSapin

Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Moggers added a commit to Moggers/servo that referenced this issue Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.