Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting enter in a text box adds a space #20630

Open
cbrewster opened this issue Apr 12, 2018 · 3 comments
Open

Hitting enter in a text box adds a space #20630

cbrewster opened this issue Apr 12, 2018 · 3 comments
Labels
A-content/dom A-input

Comments

@cbrewster
Copy link
Member

@cbrewster cbrewster commented Apr 12, 2018

Test Case:
<input type="text"/>

  1. Type in textbox
  2. Hit enter
  3. Space is added to end of text
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Apr 13, 2018 •
edited

If it's a regression, 2 PRs to check: #19895 and #20327
@kwonoj kwonoj mentioned this issue Apr 30, 2018
Closed
@atouchet
Copy link
Contributor

@atouchet atouchet commented Apr 30, 2018

I don't think this is a recent regression at the very least. I've been able to reproduce the bug in builds going back to mid-2017. I haven't tested past that.
@kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 30, 2018

I could see some pictures around why this is happening (note: appended char is \r, not space) but need to simmer bit more time to present some PR to discuss further. I'll try bit more.
This was referenced May 1, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-input
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix(window): set enter key as non-printable char
4 participants
@paulrouget @kwonoj @cbrewster @atouchet
You can’t perform that action at this time.