Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jemalloc-sys and unfork jemallocator #20645

Open
SimonSapin opened this issue Apr 16, 2018 · 1 comment
Open

Update jemalloc-sys and unfork jemallocator #20645

SimonSapin opened this issue Apr 16, 2018 · 1 comment

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 16, 2018

In #20641 we duplicated ~70 lines from the jemallocator crate in order to be able to keep using an order jemalloc-sys, because the new one doesn’t build on our Android infra:

/home/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/jemalloc-sys-0.1.5/jemalloc/src/background_thread.c:83:2: error: unknown type name 'cpu_set_t'

Upstream issue: jemalloc/jemalloc#1175

@SimonSapin
Copy link
Member Author

@SimonSapin SimonSapin commented Apr 16, 2018

Also being discussed at gnzlbg/jemallocator#34 (comment)

@gnzlbg gnzlbg mentioned this issue May 22, 2018
2 of 4 tasks complete
bors-servo added a commit that referenced this issue May 30, 2018
Update to latest jemallocator and jemalloc-sys

Updates the allocator component to use the latest jemallocator.

cc @SimonSapin

- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #20645

- [x] There are tests for these changes: everything that allocates memory tests them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20848)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 30, 2018
Update to latest jemallocator and jemalloc-sys

Updates the allocator component to use the latest jemallocator.

cc @SimonSapin

- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #20645

- [x] There are tests for these changes: everything that allocates memory tests them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20848)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 30, 2018
Update to latest jemallocator and jemalloc-sys

Updates the allocator component to use the latest jemallocator.

cc @SimonSapin

- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [x] These changes fix #20645

- [x] There are tests for these changes: everything that allocates memory tests them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20848)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.