Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTyping "3" in an input field doesn't work #20681
Comments
|
I just reproduced it. amazing... |
|
maybe regression caused by #20327 ? I'll try to repro and bisect without changes. |
I just checked, and |
|
Nailed it, it is a regression caused by me, but in different PR than #20327. I did assign a new hotkey for capture webrender in #20315, https://github.com/servo/servo/pull/20315/files#diff-4d1fd4a873c7f3f5e352fad96ac6db87R1233 and it is aggressively eats up keyevent when it doesn't match with modifier combination, ends up with omitting actual keyevent. I'll try to fix this. (not sure I can assign via @highfive |
|
@highfive assign me |
|
Hey @kwonoj! Thanks for your interest in working on this issue. It's now assigned to you! |
fix(browser): do not omit unexpected keyevent <!-- Please describe your changes on the following line: --> - closes #20681 This PR intends to fix regression caused by changes I created in #20315. In code, it matches keyevent aggressively for any pattern includes `Some('3')`, ends up actual key event does not bubbles up. This PR applies correct pattern guard to pick up specific keyevent only, other events falls back to default patterns. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20681 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ - manually verified 1. typing `3` in input field works 2. ctrl-shift-3 create webrender capture (verified on mac os) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20687) <!-- Reviewable:end -->
fix(browser): do not omit unexpected keyevent <!-- Please describe your changes on the following line: --> - closes #20681 This PR intends to fix regression caused by changes I created in #20315. In code, it matches keyevent aggressively for any pattern includes `Some('3')`, ends up actual key event does not bubbles up. This PR applies correct pattern guard to pick up specific keyevent only, other events falls back to default patterns. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [ ] `./mach build-geckolib` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20681 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ - manually verified 1. typing `3` in input field works 2. ctrl-shift-3 create webrender capture (verified on mac os) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20687) <!-- Reviewable:end -->
- closes servo#20681
While all other num keys work... A cursory look didn't surface an obvious typo or cut/paste error...