Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing "3" in an input field doesn't work #20681

Closed
fabricedesre opened this issue Apr 23, 2018 · 6 comments · Fixed by #20687
Closed

Typing "3" in an input field doesn't work #20681

fabricedesre opened this issue Apr 23, 2018 · 6 comments · Fixed by #20687
Labels
C-assigned There is someone working on resolving the issue

Comments

@fabricedesre
Copy link
Contributor

While all other num keys work... A cursory look didn't surface an obvious typo or cut/paste error...
@tigercosmos
Copy link
Contributor

I just reproduced it. amazing...

@kwonoj
Copy link
Contributor

kwonoj commented Apr 23, 2018

maybe regression caused by #20327 ? I'll try to repro and bisect without changes.

@fabricedesre
Copy link
Contributor Author

maybe regression caused by #20327 ? I'll try to repro and bisect without changes.

I just checked, and is_identifier_ignorable returns false in this case, so this is not the cause.

@kwonoj
Copy link
Contributor

kwonoj commented Apr 24, 2018 •
edited

Nailed it, it is a regression caused by me, but in different PR than #20327.

I did assign a new hotkey for capture webrender in #20315, https://github.com/servo/servo/pull/20315/files#diff-4d1fd4a873c7f3f5e352fad96ac6db87R1233 and it is aggressively eats up keyevent when it doesn't match with modifier combination, ends up with omitting actual keyevent.

I'll try to fix this. (not sure I can assign via @highfive 🤔 )

@kwonoj
Copy link
Contributor

kwonoj commented Apr 24, 2018

@highfive assign me

@highfive highfive added the C-assigned There is someone working on resolving the issue label Apr 24, 2018
@highfive
Copy link

Hey @kwonoj! Thanks for your interest in working on this issue. It's now assigned to you!

kwonoj added a commit to kwonoj/servo that referenced this issue Apr 24, 2018
@kwonoj
fix(browser): do not omit unexpected keyevent
8c9aca2 
- closes servo#20681
@kwonoj kwonoj mentioned this issue Apr 24, 2018
Merged
6 tasks
bors-servo pushed a commit that referenced this issue Apr 24, 2018
Auto merge of #20687 - kwonoj:fix-capture-wr-guard, r=KiChjang
258ac24 
fix(browser): do not omit unexpected keyevent

<!-- Please describe your changes on the following line: -->
- closes #20681

This PR intends to fix regression caused by changes I created in #20315. In code, it matches keyevent aggressively for any pattern includes `Some('3')`, ends up actual key event does not bubbles up. This PR applies correct pattern guard to pick up specific keyevent only, other events falls back to default patterns.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20681 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- manually verified
1. typing `3` in input field works
2. ctrl-shift-3 create webrender capture (verified on mac os)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20687)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 24, 2018
Auto merge of #20687 - kwonoj:fix-capture-wr-guard, r=KiChjang
9c6d9f6 
fix(browser): do not omit unexpected keyevent

<!-- Please describe your changes on the following line: -->
- closes #20681

This PR intends to fix regression caused by changes I created in #20315. In code, it matches keyevent aggressively for any pattern includes `Some('3')`, ends up actual key event does not bubbles up. This PR applies correct pattern guard to pick up specific keyevent only, other events falls back to default patterns.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20681 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- manually verified
1. typing `3` in input field works
2. ctrl-shift-3 create webrender capture (verified on mac os)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20687)
<!-- Reviewable:end -->
Moggers pushed a commit to Moggers/servo that referenced this issue Jun 13, 2018
@kwonoj @Moggers
fix(browser): do not omit unexpected keyevent
8ac0911 
- closes servo#20681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned There is someone working on resolving the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(browser): do not omit unexpected keyevent kwonoj/servo
4 participants
@fabricedesre @kwonoj @highfive @tigercosmos