Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of Unicode serialisation of origins #20701

Closed
nox opened this issue Apr 27, 2018 · 3 comments
Closed

Remove usage of Unicode serialisation of origins #20701

nox opened this issue Apr 27, 2018 · 3 comments
Labels
A-content/dom I-spec-update

Comments

@nox
Copy link
Member

@nox nox commented Apr 27, 2018

https://html.spec.whatwg.org/multipage/#ascii-serialisation-of-an-origin

There used to also be a Unicode serialization of an origin. However, it was never widely adopted.
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Jun 13, 2018

What do you think we could fix this? I am confused about "it was never widely adopted". Does it mean this is not important at all?
@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented Jun 14, 2018

@tigercosmos I guess, maybe, it means it's rarely for people to use unicode as domain?
@jdm
Copy link
Member

@jdm jdm commented Jun 14, 2018

https://github.com/servo/servo/blob/master/components/url/origin.rs#L90 is our code that allows access to this. We should presumably remove it and fix any code that relies on it.
Eijebong added a commit to Eijebong/servo that referenced this issue Oct 11, 2018
@Eijebong
Remove Origin::unicode_serialization
1741003 
Fixes servo#20701
@Eijebong Eijebong mentioned this issue Oct 11, 2018
Merged
bors-servo added a commit that referenced this issue Oct 12, 2018
@bors-servo
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
275a13c 
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Oct 12, 2018
@Eijebong
Remove Origin::unicode_serialization
a97ba4f 
Fixes servo#20701
bors-servo added a commit that referenced this issue Oct 12, 2018
@bors-servo
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
49a3554 
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Oct 13, 2018
@bors-servo
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a9eaed4 
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom I-spec-update
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @nox @CYBAI @tigercosmos
You can’t perform that action at this time.