Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebrender capture doesn't work in macOS nightly builds by default #20746
Comments
|
Which platform does it occurs? |
|
Nevermind, this definitely works when I run it from a local build. I'll try using a nightly build. |
|
When I run a nightly build on macOS and watch my terminal output, I receive |
jdm
changed the title
|
This looks like pkged nightly try to access path application path, not allowed to write. Any suggestions for preferred path? I'll try to update path lookup. |
|
Perhaps fall back to the home dir if there's an error creating the path in the working directory? |
|
I'm not sure if this is related, but Ctrl+Shift+3 seems to be broken on Linux64. Nothing happens when I press it, no files or errors. Tested just now with the latest nightly and ~ 10 days ago with the newest nightly at that time. |
it's unrelated, currently winit sends kbd event somewhat unexpectedly with ctrl on linux / win. Related issues / discussions are at #20331, #20327, #20726. I'm interested in general refactorings around those area, waiting #20331 's progress first. |
Oh, I see. Is there any workaround for the time being? Is there anyway else to trigger a capture? |
With current build as-is, it might be somewhat hard. I noticed keep trying (keep pressing ctrl-shift-3) one time did work sometimes, but not reliably. |
fix(capture_webrender): try fallback capture dir <!-- Please describe your changes on the following line: --> This PR try to update behavior of webrender capture to have fallback dir - first it try to create under current working dir, if fails go back to $TMPDIR. I was debating between TMP vs $home, bit hesitate to create some folder under user's home dir directly so choose TMP instead. Can be easily changed, or add few more if needed. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20746 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ - locally verified on mac os <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20750) <!-- Reviewable:end -->
Pressing ctr+shift+3 in master doesn't cause any new file to appear in the working directory.