Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upintermittent sigsegv in text_util unit tests #20756
Comments
|
FYI @KiChjang |
|
This has happened at least four times (in builds from both #20754 and #20615). All the instances I've seen are from the same machine, servo-mac2. cc @edunham |
|
I pulled the binary off of the machine and it continued to segfault. I'm not sure if that means anything. |
|
Maybe the rlib for one of the standard libraries on this machine is corrupt. Since it's statically linked to the binary, that would make the binary fail everywhere. We could try |
|
Seems like a perma failure to me. |
|
This has now been observed on servo-mac4 as well (#20766 (comment)). |
|
cc @aneeshusa |
|
One possibility to work around this and allow merges to continue would be removing servo-mac2 and servo-mac4 from the pool of builders for mac-dev-unit at https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/master.cfg#L178. |
|
If the issue is nondeterministic codegen in rustc, we could try disabling codegen-units to see if it affects the output. |
Disable codegen-units on macOS If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20795) <!-- Reviewable:end -->
Disable codegen-units on macOS If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20795) <!-- Reviewable:end -->
Disable codegen-units on macOS If this makes #20756 go away, it suggests a rustc non-deterministic compilation bug. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20795) <!-- Reviewable:end -->
|
Observed on servo-mac7 as well (http://build.servo.org/builders/mac-dev-unit/builds/11897/steps/test/logs/stdio). |
|
I can reproduce the exact same issue on servo-mac2 with the following testcase: #[test]
fn foo() {}and running |
Revert "Upgrade to rustc 1.27.0-nightly (8a37c75a3 2018-05-02)" This is causing us to hit a mac bug in rustc that I'm still tracking down and ruining our ability to merge PRs. This works around #20756 until the problem is fixed upstream. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20820) <!-- Reviewable:end -->
http://build.servo.org/builders/mac-dev-unit/builds/11840/steps/test/logs/stdio
I've run the binary under a debugger and it appears to be a rustc problem, since it crashes in standard library code before actually running any test code.