Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling issues #20762

Closed
atouchet opened this issue May 8, 2018 · 5 comments
Closed

Scrolling issues #20762

atouchet opened this issue May 8, 2018 · 5 comments

Comments

@atouchet
Copy link
Contributor

@atouchet atouchet commented May 8, 2018

In the latest nightly builds scrolling does not work properly, it is slow or unresponsive. This regression first occurred in the 2018-05-06 nightly build. Tested in Windows 10.

@mrobinson
Copy link
Member

@mrobinson mrobinson commented May 9, 2018

It seems like this may be a regression from the Gleam/WebRender update. I don't see the scrolling issues before that commit.

cc @nox

@nox
Copy link
Member

@nox nox commented May 9, 2018

The gleam update changes nothing functionally, so probably a WR issue.

@nox
Copy link
Member

@nox nox commented May 9, 2018

Cc @glennw

@mrobinson
Copy link
Member

@mrobinson mrobinson commented May 9, 2018

I'll try bisecting the list of changes in WebRender.

@mrobinson
Copy link
Member

@mrobinson mrobinson commented May 9, 2018

Looks like the culprit is servo/webrender#2691.

mrobinson added a commit to mrobinson/servo that referenced this issue May 9, 2018
This no longer happens automatically in WebRender, so we must do it
manually.

Fixes servo#20762.
@mrobinson mrobinson mentioned this issue May 9, 2018
4 of 5 tasks complete
bors-servo added a commit that referenced this issue May 9, 2018
Generate a frame when a transaction scrolls

This no longer happens automatically in WebRender, so we must do it
manually.

Fixes #20762.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20762.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because Servo does not currently test scrolling in a reliable way.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20766)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 17, 2018
Generate a frame when a transaction scrolls

This no longer happens automatically in WebRender, so we must do it
manually.

Fixes #20762.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20762.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because Servo does not currently test scrolling in a reliable way.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20766)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.