Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement overflow directions in layout/query.rs #20867

Open
tigercosmos opened this issue May 26, 2018 · 1 comment
Open

implement overflow directions in layout/query.rs #20867

tigercosmos opened this issue May 26, 2018 · 1 comment
Labels
A-layout/query

Comments

@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented May 26, 2018

Currently overflow_direction in the layout is just a hard code which is always to be OverflowDirection::RightAndDown

SPEC: https://drafts.csswg.org/cssom-view/#overflow-directions

servo/components/layout/query.rs

Lines 388 to 399 in 0ff6f32

impl UnioningFragmentScrollAreaIterator {
fn new(node_address: OpaqueNode) -> UnioningFragmentScrollAreaIterator {
UnioningFragmentScrollAreaIterator {
node_address: node_address,
union_rect: Rect::zero(),
origin_rect: Rect::zero(),
level: None,
is_child: false,
overflow_direction: OverflowDirection::RightAndDown
}
}
}

@tigercosmos tigercosmos mentioned this issue May 26, 2018
Merged
3 of 5 tasks complete
@tigercosmos tigercosmos changed the title implement overflow directions in layout.rs implement overflow directions in layout/query.rs May 27, 2018
bors-servo added a commit that referenced this issue May 28, 2018
@bors-servo
Auto merge of #20868 - tigercosmos:gg1, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7cc4165 
fix logic in overflow_direction, also add a FIXME

<!-- Please describe your changes on the following line: -->
This PR fix #19477, which the logic is obviously wrong.

However, it is impossible to add a test for this.

Due to #20867, the ` overflow_direction` is a hard code now. It never go to other conditions.
I add a FIXME there, and also add a SPEC link.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19477(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20868)
<!-- Reviewable:end -->
@tigercosmos
Copy link
Collaborator Author

@tigercosmos tigercosmos commented May 29, 2018

Could someone help to add layout/query label? thanks
@jdm jdm added the A-layout/query label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/query
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @tigercosmos
You can’t perform that action at this time.