Compile error with mozjs_sys in macOS 10.12.6 #20971

CYBAI · 2018-06-06T15:54:37Z

Refer to #20958 (comment)

Let me share the first error log here

I always built failed on macOS 10.12.6 with latest master (a07c718) with ./mach build -d

error: incorrect close delimiter: `]`
     --> /Users/chengyou.bai/Documents/cybai/servo/target/debug/build/mozjs_sys-d4d4cc1e26ce451a/out/jsapi.rs:10722:43
      |
10722 |             # [ derive ( Copy ) ]; 1usize ] , _bindgen_union_align : u64 , }            # [ test ]
      |                                           ^
      |
note: unclosed delimiter
     --> /Users/chengyou.bai/Documents/cybai/servo/target/debug/build/mozjs_sys-d4d4cc1e26ce451a/out/jsapi.rs:10465:24
      |
10465 |         pub mod shadow {
      |                        ^

error: unexpected close delimiter: `}`
     --> /Users/chengyou.bai/Documents/cybai/servo/target/debug/build/mozjs_sys-d4d4cc1e26ce451a/out/jsapi.rs:11882:5
      |
11882 |     }
      |     ^

error: aborting due to 2 previous errors

The following warnings were emitted during compilation:

warning: In file included from src/jsglue.cpp:7:
warning: src/jsglue.hpp:86:16: warning: private field 'argv_' is not used [-Wunused-private-field]
warning:     JS::Value* argv_;
warning:                ^
warning: src/jsglue.hpp:87:14: warning: private field 'argc_' is not used [-Wunused-private-field]
warning:     unsigned argc_;
warning:              ^
warning: src/jsglue.hpp:88:10: warning: private field 'constructing_' is not used [-Wunused-private-field]
warning:     bool constructing_:1;
warning:          ^
warning: src/jsglue.hpp:89:10: warning: private field 'ignoresReturnValue_' is not used [-Wunused-private-field]
warning:     bool ignoresReturnValue_:1;
warning:          ^
warning: 4 warnings generated.

error: Could not compile `mozjs_sys`.
warning: build failed, waiting for other jobs to finish...
error: build failed
Build FAILED in 0:22:05

LLVM version

→ llvm-gcc -v
Apple LLVM version 9.0.0 (clang-900.0.39.2)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

and in #20958 (comment), @asajeffrey asked me to try to build mozjs itself.

After cargo build the mozjs, I got same error logs

   Compiling mozjs_sys v0.51.1 (file:///Users/chengyou.bai/Documents/cybai/mozjs)
warning: In file included from src/jsglue.cpp:7:
warning: src/jsglue.hpp:86:16: warning: private field 'argv_' is not used [-Wunused-private-field]
warning:     JS::Value* argv_;
warning:                ^
warning: src/jsglue.hpp:87:14: warning: private field 'argc_' is not used [-Wunused-private-field]
warning:     unsigned argc_;
warning:              ^
warning: src/jsglue.hpp:88:10: warning: private field 'constructing_' is not used [-Wunused-private-field]
warning:     bool constructing_:1;
warning:          ^
warning: src/jsglue.hpp:89:10: warning: private field 'ignoresReturnValue_' is not used [-Wunused-private-field]
warning:     bool ignoresReturnValue_:1;
warning:          ^
warning: 4 warnings generated.
error: incorrect close delimiter: `]`
     --> /Users/chengyou.bai/Documents/cybai/mozjs/target/debug/build/mozjs_sys-c78b17b647610923/out/jsapi.rs:10722:43
      |
10722 |             # [ derive ( Copy ) ]; 1usize ] , _bindgen_union_align : u64 , }            # [ test ]
      |                                           ^
      |
note: unclosed delimiter
     --> /Users/chengyou.bai/Documents/cybai/mozjs/target/debug/build/mozjs_sys-c78b17b647610923/out/jsapi.rs:10465:24
      |
10465 |         pub mod shadow {
      |                        ^

error: unexpected close delimiter: `}`
     --> /Users/chengyou.bai/Documents/cybai/mozjs/target/debug/build/mozjs_sys-c78b17b647610923/out/jsapi.rs:11882:5
      |
11882 |     }
      |     ^

The following warnings were emitted during compilation:

warning: In file included from src/jsglue.cpp:7:
warning: src/jsglue.hpp:86:16: warning: private field 'argv_' is not used [-Wunused-private-field]
warning:     JS::Value* argv_;
warning:                ^
warning: src/jsglue.hpp:87:14: warning: private field 'argc_' is not used [-Wunused-private-field]
warning:     unsigned argc_;
warning:              ^
warning: src/jsglue.hpp:88:10: warning: private field 'constructing_' is not used [-Wunused-private-field]
warning:     bool constructing_:1;
warning:          ^
warning: src/jsglue.hpp:89:10: warning: private field 'ignoresReturnValue_' is not used [-Wunused-private-field]
warning:     bool ignoresReturnValue_:1;
warning:          ^
warning: 4 warnings generated.

error: Could not compile `mozjs_sys`.

To learn more, run the command again with --verbose.

CYBAI · 2018-06-06T16:01:07Z

@asajeffrey Here's the gist which I built mozjs with cargo build -v

asajeffrey · 2018-06-06T16:02:59Z

@CYBAI hmm, that gist doesn't show jsapi.rs being generated. Can you remove jsapi.rs and re-run?

CYBAI · 2018-06-06T16:03:58Z

@asajeffrey ohh, ok, let me remove it and re-run it.

CYBAI · 2018-06-06T16:14:38Z

@asajeffrey Updated the gist but the log looks similar to previous version. 😭 Not sure if I miss anything?

asajeffrey · 2018-06-06T16:21:22Z

@emilio: this is odd, bindgen is producing a syntactically invalid .rs file, have you seen this before?

asajeffrey · 2018-06-06T16:29:22Z

@CYBAI can you give us a snippet of /Users/chengyou.bai/Documents/cybai/mozjs/target/debug/build/mozjs_sys-c78b17b647610923/out/jsapi.rs, say about 20 lines before and after line 10722?

jdm · 2018-06-06T16:34:10Z

I'm building on macOS 10.12.6 without any problems, as a point of reference.

CYBAI · 2018-06-06T16:37:46Z

@asajeffrey Here's line 10654 to line 10762 for the mozjs/target/debug/build/mozjs_sys-c78b17b647610923/out/jsapi.rs

# [ test ]
fn bindgen_test_layout_Function() {
    assert_eq!(::std::mem::size_of::<Function>(),
                64usize,
                concat!("Size of: ", stringify!(Function)));
    assert_eq!(::std::mem::align_of::<Function>(),
                8usize,
                concat!("Alignment of ", stringify!(Function)));
    assert_eq!(unsafe {
                    &(*(::std::ptr::null::<Function>())).base as *const _ as usize
                },
                0usize,
                concat!("Offset of field: ",
                        stringify!(Function),
                        "::",
                        stringify!(base)));
    assert_eq!(unsafe {
                    &(*(::std::ptr::null::<Function>())).nargs as *const _ as usize
                },
                32usize,
                concat!("Offset of field: ",
                        stringify!(Function),
                        "::",
                        stringify!(nargs)));
    assert_eq!(unsafe {
                    &(*(::std::ptr::null::<Function>())).flags as *const _ as usize
                },
                34usize,
                concat!("Offset of field: ",
                        stringify!(Function),
                        "::",
                        stringify!(flags)));
    assert_eq!(unsafe {
                    &(*(::std::ptr::null::<Function>())).native as *const _ as usize
                },
                40usize,
                concat!("Offset of field: ",
                        stringify!(Function),
                        "::",
                        stringify!(native)));
    assert_eq!(unsafe {
                    &(*(::std::ptr::null::<Function>())).jitinfo as *const _ as usize
                },
                48usize,
                concat!("Offset of field: ",
                        stringify!(Function),
                        "::",
                        stringify!(jitinfo)));
    assert_eq!(unsafe { &(*(::std::ptr::null::<Function>()))._1 as *const _ as usize },
                56usize,
                concat!("Offset of field: ",
                        stringify!(Function),
                        "::",
                        stringify!(_1)));
}
impl Clone for Function {
    fn clone(&self) -> Self {
        *self
    }
}
# [ repr ( C ) ]
# [ derive ( Copy ) ]
pub struct String {
    pub flags: u32,
    pub length: u32,
    pub __bindgen_anon_1: root::js::shadow::String__bindgen_ty_1,
}
# [ repr ( C ) ]
# [ derive ( Copy ) ]; 1usize ] , _bindgen_union_align : u64 , }            # [ test ]
fn bindgen_test_layout_String__bindgen_ty_1() {
    assert_eq!(::std::mem::size_of::<String__bindgen_ty_1>(),
                8usize,
                concat!("Size of: ", stringify!(String__bindgen_ty_1)));
    assert_eq!(::std::mem::align_of::<String__bindgen_ty_1>(),
                8usize,
                concat!("Alignment of ", stringify!(String__bindgen_ty_1)));
    assert_eq!(unsafe {
                    & ( * ( :: std :: ptr :: null :: < String__bindgen_ty_1 > ( ) ) ) . nonInlineCharsLatin1 as * const _ as usize
                },
                0usize,
                concat!("Offset of field: ",
                        stringify!(String__bindgen_ty_1),
                        "::",
                        stringify!(nonInlineCharsLatin1)));
    assert_eq!(unsafe {
                    & ( * ( :: std :: ptr :: null :: < String__bindgen_ty_1 > ( ) ) ) . nonInlineCharsTwoByte as * const _ as usize
                },
                0usize,
                concat!("Offset of field: ",
                        stringify!(String__bindgen_ty_1),
                        "::",
                        stringify!(nonInlineCharsTwoByte)));
    assert_eq!(unsafe {
                    & ( * ( :: std :: ptr :: null :: < String__bindgen_ty_1 > ( ) ) ) . inlineStorageLatin1 as * const _ as usize
                },
                0usize,
                concat!("Offset of field: ",
                        stringify!(String__bindgen_ty_1),
                        "::",
                        stringify!(inlineStorageLatin1)));
    assert_eq!(unsafe {
                    & ( * ( :: std :: ptr :: null :: < String__bindgen_ty_1 > ( ) ) ) . inlineStorageTwoByte as * const _ as usize
                },
                0usize,
                concat!("Offset of field: ",
                        stringify!(String__bindgen_ty_1),
                        "::",
                        stringify!(inlineStorageTwoByte)));
}

asajeffrey · 2018-06-06T16:48:04Z

The matching snippet from my jsapi,rs is:

...
# [ repr ( C ) ]
# [ derive ( Copy ) ]
pub struct String {
    pub flags : u32 ,
    pub length : u32 ,
    pub __bindgen_anon_1 : root::js::shadow::String__bindgen_ty_1 ,
}
# [ repr ( C ) ]
# [ derive ( Copy ) ]
pub union String__bindgen_ty_1 {
    pub nonInlineCharsLatin1 : * const root::JS::Latin1Char ,
    pub nonInlineCharsTwoByte : * const u16 ,
    pub inlineStorageLatin1 : [ root::JS::Latin1Char ; 1usize ] ,
    pub inlineStorageTwoByte : [ u16 ; 1usize ] ,
    _bindgen_union_align : u64 ,
}
# [ test ]
fn bindgen_test_layout_String__bindgen_ty_1 ( ) {
...

For some reason, most of String__bindgen_ty_1 isn't being emitted.

KiChjang · 2018-06-06T22:13:02Z

I'm also building servo fine on my MacOS 10.12.6.

SughiY · 2018-07-15T19:41:46Z

Hello,
I fell into the same situation. And I think this should be an issue introduced by rustfmt according to rust-lang-nursery/rust-bindgen#1045 and RustAudio/coreaudio-sys#7. I have tried the solution in rust-lang-nursery/rust-bindgen#1045 by disabling the rust_fmt and it works well. I wonder why we had this error as the default compiler is already the nightly version.

CYBAI · 2018-07-28T06:24:05Z

Yes, as @SughiY mentioned.

I can solve the issue by doing following commands

$ cargo uninstall rustfmt
$ rustup component add rustfmt-preview

asajeffrey · 2018-07-28T12:58:47Z

Yes, that's a rustfmt version problem. According to fitzgen, there's a line we can add to the rustfmt config file giving the minimum version. This won't fix the problem, but at least the error message will be understandable.

gaurikholkar · 2018-08-20T18:27:21Z

Any updates on the same? I am running rustfmt 0.8.2-nightly (5e599251 2018-07-02), rustc 1.29.0-nightly (1ecf6929d 2018-07-16) and it is giving me the same error.

jdm · 2018-08-20T19:44:23Z

@gaurikholkar Did you follow #20971 (comment)?

gaurikholkar · 2018-08-21T04:13:25Z

Yes @jdm but it's still giving me an error

CYBAI · 2020-04-11T15:19:44Z

I think this is no longer an issue.

jdm added P-mac A-build labels Jun 6, 2018

CYBAI closed this Apr 11, 2020

servo / servo

Compile error with mozjs_sys in macOS 10.12.6 #20971

Compile error with mozjs_sys in macOS 10.12.6 #20971

CYBAI commented Jun 6, 2018

CYBAI commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

CYBAI commented Jun 6, 2018

CYBAI commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

jdm commented Jun 6, 2018

CYBAI commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

KiChjang commented Jun 6, 2018 •

edited

SughiY commented Jul 15, 2018 •

edited by jdm

CYBAI commented Jul 28, 2018

asajeffrey commented Jul 28, 2018

gaurikholkar commented Aug 20, 2018 •

edited

jdm commented Aug 20, 2018

gaurikholkar commented Aug 21, 2018

CYBAI commented Apr 11, 2020

servo / servo

Join GitHub today

Compile error with mozjs_sys in macOS 10.12.6 #20971

Compile error with mozjs_sys in macOS 10.12.6 #20971

Comments

CYBAI commented Jun 6, 2018

CYBAI commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

CYBAI commented Jun 6, 2018

CYBAI commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

jdm commented Jun 6, 2018

CYBAI commented Jun 6, 2018

asajeffrey commented Jun 6, 2018

KiChjang commented Jun 6, 2018 • edited

SughiY commented Jul 15, 2018 • edited by jdm

CYBAI commented Jul 28, 2018

asajeffrey commented Jul 28, 2018

gaurikholkar commented Aug 20, 2018 • edited

jdm commented Aug 20, 2018

gaurikholkar commented Aug 21, 2018

CYBAI commented Apr 11, 2020

KiChjang commented Jun 6, 2018 •

edited

SughiY commented Jul 15, 2018 •

edited by jdm

gaurikholkar commented Aug 20, 2018 •

edited