Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo crashes when redirecting to an HTTPS page #2104

Closed
jdm opened this issue Apr 14, 2014 · 2 comments
Closed

Servo crashes when redirecting to an HTTPS page #2104

jdm opened this issue Apr 14, 2014 · 2 comments
Labels

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 14, 2014

Even though we don't support HTTPS, we should make this experience better (ie. I Tried star).

@jdm
Copy link
Member Author

@jdm jdm commented Apr 15, 2014

It should be easy to turn this into a fallible network load instead of a hard task failure. Whether the rest of Servo will still avoid crashing when that happens is an open question :)

@jdm
Copy link
Member Author

@jdm jdm commented Apr 15, 2014

Relevant source: the assert about http:// schemes at http://mxr.mozilla.org/servo/source/src/components/net/http_loader.rs#55

campadrenalin added a commit to campadrenalin/servo that referenced this issue Apr 18, 2014
campadrenalin added a commit to campadrenalin/servo that referenced this issue Apr 18, 2014
campadrenalin added a commit to campadrenalin/servo that referenced this issue Apr 18, 2014
campadrenalin added a commit to campadrenalin/servo that referenced this issue Apr 19, 2014
@jdm jdm closed this Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.