Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEventSource should use 'remote event task source' #21112
Closed
Labels
Comments
bors-servo
added a commit
that referenced
this issue
Jul 13, 2018
…tsource, r=jdm Use remote-event task source in EventSource <!-- Please describe your changes on the following line: --> Follow up on #21126, this again 'changes nothing', but will be useful for #21111 in the context of #21114 Trying to break up work into smaller PR's ;) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #21112 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 13, 2018
…tsource, r=jdm Use remote-event task source in EventSource <!-- Please describe your changes on the following line: --> Follow up on #21126, this again 'changes nothing', but will be useful for #21114 in the context of #21111. Trying to break up work into smaller PR's ;) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #21112 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 14, 2018
…tsource, r=jdm Use remote-event task source in EventSource <!-- Please describe your changes on the following line: --> Follow up on #21126, this again 'changes nothing', but will be useful for #21114 in the context of #21111. Trying to break up work into smaller PR's ;) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #21112 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the networking task source is used to queue tasks scheduled by the EventSource object. See for example
servo/components/script/dom/eventsource.rs
Line 124 in c71c55e
The spec says that we should use the remote event task source
The current situation can create problem in the context of aborting a document
The problem is that when we 'abort a document', we'll also discard all networking tasks.
If there is an ongoing fetch related to an EventSource, we need to cancel it, and then fail the connection, which is done via a task.
If we use the networking task source for this task, it will probably be discarded as part of 'abort a document', hence highligting the need to use the 'remote event task source'.
See whatwg/html#3789
I might end up doing this as part of #19309