Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MotionMark webgl benchmark doesn't do anything (offsetWidth/offsetHeight of body is 0) #21174

Open
jdm opened this issue Jul 13, 2018 · 2 comments
Open

Comments

@jdm jdm added the A-content/webgl label Jul 13, 2018
@jdm
Copy link
Member Author

@jdm jdm commented Jul 13, 2018

I've verified that it's running the animate function from https://searchfox.org/mozilla-central/source/third_party/webkit/PerformanceTests/MotionMark/tests/3d/resources/webgl.js#135, so I'm not really sure what's going wrong.

@jdm
Copy link
Member Author

@jdm jdm commented Jul 13, 2018

This is caused by this snippet during the test initialization:

        this._element.setAttribute("width", document.body.offsetWidth);
        this._element.setAttribute("height", document.body.offsetHeight);

In Servo document.body.offsetWidth and document.body.offsetHeight return 0, which sets the canvas element's logical width and height to 0, therefore displaying nothing. Sigh.

@jdm jdm changed the title MotionMark webgl benchmark doesn't do anything MotionMark webgl benchmark doesn't do anything (offsetWidth/offsetHeight of body is 0) Jul 13, 2018
@jdm jdm added A-layout/query and removed A-content/webgl labels Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.